* Re: master 508d24c8b9a 4/4: ; Silence byte-compiler
[not found] ` <20230816194549.20049C323E3@vcs2.savannah.gnu.org>
@ 2023-08-17 9:29 ` Basil L. Contovounesios
2023-08-20 18:28 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Basil L. Contovounesios @ 2023-08-17 9:29 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
Stefan Kangas [2023-08-16 15:45 -0400] wrote:
> branch: master
Why not emacs-29?
> commit 508d24c8b9aee2c2a4c78ccfef3b5f551a1b2115
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
> ; Silence byte-compiler
>
> * test/src/comp-tests.el (native-comp-eln-load-path): Declare.
> ---
> test/src/comp-tests.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/src/comp-tests.el b/test/src/comp-tests.el
> index 2fd70585628..4444ab61219 100644
> --- a/test/src/comp-tests.el
> +++ b/test/src/comp-tests.el
> @@ -64,6 +64,7 @@
>
> \f
>
> +(defvar native-comp-eln-load-path)
> (ert-deftest comp-tests-bootstrap ()
> "Compile the compiler and load it to compile it-self.
> Check that the resulting binaries do not differ."
Would it be better to move the declaration within the test's body,
which is tagged as :nativecomp? Or is the warning emitted in
--with-native-compilation builds as well?
Thanks,
--
Basil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 508d24c8b9a 4/4: ; Silence byte-compiler
2023-08-17 9:29 ` master 508d24c8b9a 4/4: ; Silence byte-compiler Basil L. Contovounesios
@ 2023-08-20 18:28 ` Stefan Kangas
2023-08-21 1:35 ` Basil L. Contovounesios
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2023-08-20 18:28 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: emacs-devel
Basil L. Contovounesios <contovob@tcd.ie> writes:
> > branch: master
>
> Why not emacs-29?
I cherry-picked the change to emacs-29, thanks.
> > +(defvar native-comp-eln-load-path)
> > (ert-deftest comp-tests-bootstrap ()
> > "Compile the compiler and load it to compile it-self.
> > Check that the resulting binaries do not differ."
>
> Would it be better to move the declaration within the test's body,
> which is tagged as :nativecomp? Or is the warning emitted in
> --with-native-compilation builds as well?
Why would it be better to move it within the test's body? I see the
warning in builds without native compilation.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 508d24c8b9a 4/4: ; Silence byte-compiler
2023-08-20 18:28 ` Stefan Kangas
@ 2023-08-21 1:35 ` Basil L. Contovounesios
0 siblings, 0 replies; 3+ messages in thread
From: Basil L. Contovounesios @ 2023-08-21 1:35 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
Stefan Kangas [2023-08-20 20:28 +0200] wrote:
> Basil L. Contovounesios <contovob@tcd.ie> writes:
> I cherry-picked the change to emacs-29, thanks.
Thanks.
>> > +(defvar native-comp-eln-load-path)
>> > (ert-deftest comp-tests-bootstrap ()
>> > "Compile the compiler and load it to compile it-self.
>> > Check that the resulting binaries do not differ."
>>
>> Would it be better to move the declaration within the test's body,
>> which is tagged as :nativecomp? Or is the warning emitted in
>> --with-native-compilation builds as well?
>
> Why would it be better to move it within the test's body?
Perhaps to limit its dynamic scope to when the variable is
defined/tested, if preferred.
--
Basil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-21 1:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <169221514843.8882.13510749977508568134@vcs2.savannah.gnu.org>
[not found] ` <20230816194549.20049C323E3@vcs2.savannah.gnu.org>
2023-08-17 9:29 ` master 508d24c8b9a 4/4: ; Silence byte-compiler Basil L. Contovounesios
2023-08-20 18:28 ` Stefan Kangas
2023-08-21 1:35 ` Basil L. Contovounesios
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).