Re: master 508d24c8b9a 4/4: ; Silence byte-compiler

Re: master 508d24c8b9a 4/4: ; Silence byte-compiler

[Basil L. Contovounesios]

Stefan Kangas [2023-08-16 15:45 -0400] wrote:

> branch: master

Why not emacs-29?

> commit 508d24c8b9aee2c2a4c78ccfef3b5f551a1b2115
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
>     ; Silence byte-compiler
>     
>     * test/src/comp-tests.el (native-comp-eln-load-path): Declare.
> ---
>  test/src/comp-tests.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/test/src/comp-tests.el b/test/src/comp-tests.el
> index 2fd70585628..4444ab61219 100644
> --- a/test/src/comp-tests.el
> +++ b/test/src/comp-tests.el
> @@ -64,6 +64,7 @@
>  
>  \f
>  
> +(defvar native-comp-eln-load-path)
>  (ert-deftest comp-tests-bootstrap ()
>    "Compile the compiler and load it to compile it-self.
>  Check that the resulting binaries do not differ."

Would it be better to move the declaration within the test's body,
which is tagged as :nativecomp?  Or is the warning emitted in
--with-native-compilation builds as well?

Thanks,
-- 
Basil

Re: master 508d24c8b9a 4/4: ; Silence byte-compiler

[Stefan Kangas]

Basil L. Contovounesios <contovob@tcd.ie> writes:

> > branch: master
>
> Why not emacs-29?

I cherry-picked the change to emacs-29, thanks.

> > +(defvar native-comp-eln-load-path)
> >  (ert-deftest comp-tests-bootstrap ()
> >    "Compile the compiler and load it to compile it-self.
> >  Check that the resulting binaries do not differ."
>
> Would it be better to move the declaration within the test's body,
> which is tagged as :nativecomp?  Or is the warning emitted in
> --with-native-compilation builds as well?

Why would it be better to move it within the test's body?  I see the
warning in builds without native compilation.

Re: master 508d24c8b9a 4/4: ; Silence byte-compiler

[Basil L. Contovounesios]

Stefan Kangas [2023-08-20 20:28 +0200] wrote:
> Basil L. Contovounesios <contovob@tcd.ie> writes:
> I cherry-picked the change to emacs-29, thanks.

Thanks.

>> > +(defvar native-comp-eln-load-path)
>> >  (ert-deftest comp-tests-bootstrap ()
>> >    "Compile the compiler and load it to compile it-self.
>> >  Check that the resulting binaries do not differ."
>>
>> Would it be better to move the declaration within the test's body,
>> which is tagged as :nativecomp?  Or is the warning emitted in
>> --with-native-compilation builds as well?
>
> Why would it be better to move it within the test's body?

Perhaps to limit its dynamic scope to when the variable is
defined/tested, if preferred.

-- 
Basil