From: Stefan Kangas <stefankangas@gmail.com>
To: Thierry Volpiatto <thievol@posteo.net>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: master fe7c015b20: Support XFCE in wallpaper.el
Date: Tue, 27 Sep 2022 09:57:50 -0400 [thread overview]
Message-ID: <CADwFkm=iWDEsP6ZWMNyk2TsoY95oGbdkxYkdtnT-u3=iq9Z+xg@mail.gmail.com> (raw)
In-Reply-To: <87y1u51ddf.fsf@posteo.net>
Thierry Volpiatto <thievol@posteo.net> writes:
> 1) The function wallpaper--format-arg is evaluating the format-specs each
> time it is called and when display-graphic-p returns nil, user is
> prompted for height and width at each call.
>
> Here the xfce args:
>
> ("-c" "xfce4-desktop" "-p" "/backdrop/screen%S/monitor%M/workspace%W/last-image" "-s" "%f")
>
> We are prompted for height and width for each of these args.
The problem here is that all arguments to `format-spec' are evaluated
unconditionally.
Could we change `format-spec' to accept functions in the substitutions,
that are then only called when actually needed?
For example, from its docstring:
(format-spec "su - %u %l"
`((?u . ,(user-login-name))
(?l . "ls")))
Could then instead be:
(format-spec "su - %u %l"
`((?u . #'user-login-name)
(?l . "ls")))
Perhaps we should hide that behind a new optional argument though.
next prev parent reply other threads:[~2022-09-27 13:57 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166336105908.23797.12319380359602540227@vcs2.savannah.gnu.org>
[not found] ` <20220916204419.B124FC00872@vcs2.savannah.gnu.org>
2022-09-17 2:00 ` master fe7c015b20: Support XFCE in wallpaper.el Po Lu
2022-09-17 18:03 ` Stefan Kangas
2022-09-18 1:18 ` Po Lu
2022-09-18 2:13 ` Po Lu
2022-09-18 4:48 ` Thierry Volpiatto
2022-09-18 5:15 ` Po Lu
2022-09-18 14:44 ` Thierry Volpiatto
2022-09-19 4:49 ` Po Lu
2022-09-19 6:06 ` Thierry Volpiatto
2022-09-19 7:24 ` Po Lu
2022-09-19 8:40 ` Thierry Volpiatto
2022-09-19 8:52 ` Po Lu
2022-09-19 17:46 ` Thierry Volpiatto
2022-09-19 18:05 ` Thierry Volpiatto
2022-09-19 18:59 ` Stefan Kangas
2022-09-19 20:16 ` Tomas Hlavaty
2022-09-19 21:19 ` Stefan Monnier
2022-09-20 6:16 ` Thierry Volpiatto
2022-09-20 2:32 ` Eli Zaretskii
2022-09-20 2:43 ` Po Lu
2022-09-20 6:25 ` Thierry Volpiatto
2022-09-20 8:22 ` Po Lu
2022-09-19 7:23 ` Thierry Volpiatto
2022-09-26 19:42 ` Stefan Kangas
2022-09-26 21:01 ` Stephen Berman
2022-09-26 22:46 ` Stefan Kangas
2022-09-27 7:17 ` Stephen Berman
2022-09-27 7:45 ` Po Lu
2022-09-27 13:42 ` Stefan Kangas
2022-09-27 0:33 ` Po Lu
2022-09-27 5:56 ` Eli Zaretskii
2022-09-27 6:13 ` Po Lu
2022-09-27 6:45 ` Eli Zaretskii
2022-09-27 7:50 ` Po Lu
2022-09-27 7:56 ` Eli Zaretskii
2022-09-27 8:31 ` Po Lu
2022-09-27 7:21 ` Thierry Volpiatto
2022-09-27 7:42 ` Po Lu
2022-09-27 7:55 ` Thierry Volpiatto
2022-09-27 8:35 ` Po Lu
2022-09-27 18:33 ` Stefan Kangas
2022-09-28 0:34 ` Po Lu
2022-09-27 13:57 ` Stefan Kangas [this message]
2022-09-27 15:43 ` Visuwesh
2022-09-27 16:19 ` Stefan Kangas
2022-09-27 16:39 ` Thierry Volpiatto
2022-09-27 16:40 ` Eli Zaretskii
2022-09-27 17:01 ` Stefan Kangas
2022-09-27 17:14 ` Eli Zaretskii
2022-09-27 18:02 ` Make format-spec accept a function as the substitution Stefan Kangas
2022-09-29 6:57 ` Thierry Volpiatto
2022-09-29 12:36 ` Stefan Monnier
2022-09-29 12:59 ` Stefan Kangas
2022-09-29 15:02 ` Philip Kaludercic
2022-09-29 16:34 ` Stefan Kangas
2022-09-29 16:53 ` Philip Kaludercic
2022-09-29 17:06 ` Stefan Kangas
2022-09-29 16:56 ` Stefan Monnier
2022-09-29 15:09 ` Thierry Volpiatto
2022-09-29 16:34 ` Stefan Kangas
2022-09-29 14:16 ` master fe7c015b20: Support XFCE in wallpaper.el Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=iWDEsP6ZWMNyk2TsoY95oGbdkxYkdtnT-u3=iq9Z+xg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=thievol@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).