From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master fe7c015b20: Support XFCE in wallpaper.el Date: Tue, 27 Sep 2022 09:57:50 -0400 Message-ID: References: <166336105908.23797.12319380359602540227@vcs2.savannah.gnu.org> <20220916204419.B124FC00872@vcs2.savannah.gnu.org> <87edwavjyc.fsf@yahoo.com> <87wna1tr7z.fsf@yahoo.com> <87y1u51ddf.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36200"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 27 16:59:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odC3R-0009DH-CL for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 16:59:25 +0200 Original-Received: from localhost ([::1]:48670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odC3Q-0000kG-Ak for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 10:59:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odB5w-0001IK-KB for emacs-devel@gnu.org; Tue, 27 Sep 2022 09:57:59 -0400 Original-Received: from mail-oi1-x22a.google.com ([2607:f8b0:4864:20::22a]:40576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odB5s-0002rp-De for emacs-devel@gnu.org; Tue, 27 Sep 2022 09:57:53 -0400 Original-Received: by mail-oi1-x22a.google.com with SMTP id n124so11924808oih.7 for ; Tue, 27 Sep 2022 06:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=npYpGFRoVeImLPPdCHkVq6r/lC8k/miBeRmte/QqD4Y=; b=TYNilrXaYbP+HIOyOqcc03FflSwTm96/M3gko2K+mtCxeolnQHHeYRu7ZbpEdMjH7Q 3TxJlE7QSHSmnMZgBN9NG6yWC5NhVPHa/jD2ksiuPAAfwwChtUPax4v3x82ww9Dv32ac wQvJnzIYId5hei/NUQiEJy2bCw3Z31j+ku+zCP5r58Ixh99nwC4Dqg8TXjmI6tkH1fbZ DmMWAro1UG7omv1B+wUbrQhV+QcAsBNrmrlF5C5DoFpmRkVrMeldSoBXzYWAG4OQmB2d /kyAa1aeuImPW6eyWaaEbj5s4qecAZrQOaQRCYDo4yJumNoa+zNZoBCDyh23giYfsTVj X2gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=npYpGFRoVeImLPPdCHkVq6r/lC8k/miBeRmte/QqD4Y=; b=Z56DWRVe1irAAZ8MwNr5eJh/3+AN2pEjuaqrEydhEWbf941sClvnf033gTZvVGIJA8 l0pFgEaZaTNCsC5MxX+hnkCxvSuLxEvhaD8v6yvEvIMBYONPpcB5gZ3eU5cKRFE3oCXM DroALw1x8ndKgi7dRusxsCewaxGTS5W/oiwKLhWDU9XxGOfILjKo7Cm7MRyYU7Q7GC28 4ssGR7tY50GwsPT6tx80mECAp6L/MFOZ3DRV66/2JVRtwihyBaGEj7XSbaQymJzx6Hf5 g3D7TAEmEbQmO+YG0ezYPUQhNBbdNZAraHotv6sLBmB2WTvchDn+XFoN64+agfKRn1Bo 4SUg== X-Gm-Message-State: ACrzQf0q5YgKudsL9L9k6bUH8ltKofDQDk6sf0gnxWF2BXPDF3/bZDts OiJcd0M9pWD+fmeX5NxH0zdaEeWUGiVa8+3Yo9s= X-Google-Smtp-Source: AMsMyM5GM8iKO0gAPXto8UPWiIbKC0PDc2faD/iirJT7tVbtrpNOeEzM6CHJ7pv1Yll7b8EWHHCVePygMpGeM7M+sxQ= X-Received: by 2002:a05:6808:1688:b0:345:ea9a:2954 with SMTP id bb8-20020a056808168800b00345ea9a2954mr1867216oib.199.1664287071188; Tue, 27 Sep 2022 06:57:51 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 09:57:50 -0400 In-Reply-To: <87y1u51ddf.fsf@posteo.net> X-Hashcash: 1:20:220927:thievol@posteo.net::wFHxaYxKC4CXaL09:8+gn Received-SPF: pass client-ip=2607:f8b0:4864:20::22a; envelope-from=stefankangas@gmail.com; helo=mail-oi1-x22a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296341 Archived-At: Thierry Volpiatto writes: > 1) The function wallpaper--format-arg is evaluating the format-specs each > time it is called and when display-graphic-p returns nil, user is > prompted for height and width at each call. > > Here the xfce args: > > ("-c" "xfce4-desktop" "-p" "/backdrop/screen%S/monitor%M/workspace%W/last-image" "-s" "%f") > > We are prompted for height and width for each of these args. The problem here is that all arguments to `format-spec' are evaluated unconditionally. Could we change `format-spec' to accept functions in the substitutions, that are then only called when actually needed? For example, from its docstring: (format-spec "su - %u %l" `((?u . ,(user-login-name)) (?l . "ls"))) Could then instead be: (format-spec "su - %u %l" `((?u . #'user-login-name) (?l . "ls"))) Perhaps we should hide that behind a new optional argument though.