unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org, Thierry Volpiatto <thievol@posteo.net>
Subject: Re: master fe7c015b20: Support XFCE in wallpaper.el
Date: Mon, 26 Sep 2022 15:42:51 -0400	[thread overview]
Message-ID: <CADwFkmmHpeEr_rT24Daa-3D7Q85sy0HeF-P_OcX9Z5ard_hMaw@mail.gmail.com> (raw)
In-Reply-To: <87wna1tr7z.fsf@yahoo.com>

Po Lu <luangruo@yahoo.com> writes:

> The screen number should be the following part of the `display' frame
> parameter:
>
>   1.1.1.1:0.5
>             ^ screen number is 5
>
> if there is no period after the separator, then the screen number is 0.
>
> The currently active workspace can be obtained like so:
>
>   (x-window-property "_NET_CURRENT_DESKTOP" nil "CARDINAL" 0 nil t)
>
> if it fails by returning NULL, then you should fall back to:
>
>   (x-window-property "WIN_WORKSPACE" nil "CARDINAL" 0 nil t)
>
> and failing that, 0.
>
> The monitor name should also be easy to extract with
> display-monitor-attributes-list, but if the source is anything other
> than "XRandr", "XRandr 1.5" or "Gdk", you should fall back to using "0".

Thanks, I've pushed a fix to master based on the above.  I very much
appreciated the clear instructions above, which saved me a ton of time.

I had to jump through extra hoops to get it to work also in the
situation that Thierry described, however.  See commit b0289e7f6d and in
particular bb9df76dc9.

I installed XFCE on my machine to test the change and it works for me.
If someone with XFCE could test that the change works for them, that
would be welcome.



  parent reply	other threads:[~2022-09-26 19:42 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166336105908.23797.12319380359602540227@vcs2.savannah.gnu.org>
     [not found] ` <20220916204419.B124FC00872@vcs2.savannah.gnu.org>
2022-09-17  2:00   ` master fe7c015b20: Support XFCE in wallpaper.el Po Lu
2022-09-17 18:03     ` Stefan Kangas
2022-09-18  1:18       ` Po Lu
2022-09-18  2:13         ` Po Lu
2022-09-18  4:48         ` Thierry Volpiatto
2022-09-18  5:15           ` Po Lu
2022-09-18 14:44             ` Thierry Volpiatto
2022-09-19  4:49               ` Po Lu
2022-09-19  6:06                 ` Thierry Volpiatto
2022-09-19  7:24                   ` Po Lu
2022-09-19  8:40                     ` Thierry Volpiatto
2022-09-19  8:52                       ` Po Lu
2022-09-19 17:46                         ` Thierry Volpiatto
2022-09-19 18:05                         ` Thierry Volpiatto
2022-09-19 18:59                           ` Stefan Kangas
2022-09-19 20:16                           ` Tomas Hlavaty
2022-09-19 21:19                             ` Stefan Monnier
2022-09-20  6:16                               ` Thierry Volpiatto
2022-09-20  2:32                             ` Eli Zaretskii
2022-09-20  2:43                               ` Po Lu
2022-09-20  6:25                                 ` Thierry Volpiatto
2022-09-20  8:22                                   ` Po Lu
2022-09-19  7:23                 ` Thierry Volpiatto
2022-09-26 19:42         ` Stefan Kangas [this message]
2022-09-26 21:01           ` Stephen Berman
2022-09-26 22:46             ` Stefan Kangas
2022-09-27  7:17               ` Stephen Berman
2022-09-27  7:45                 ` Po Lu
2022-09-27 13:42                   ` Stefan Kangas
2022-09-27  0:33             ` Po Lu
2022-09-27  5:56           ` Eli Zaretskii
2022-09-27  6:13             ` Po Lu
2022-09-27  6:45               ` Eli Zaretskii
2022-09-27  7:50                 ` Po Lu
2022-09-27  7:56                   ` Eli Zaretskii
2022-09-27  8:31                     ` Po Lu
2022-09-27  7:21           ` Thierry Volpiatto
2022-09-27  7:42             ` Po Lu
2022-09-27  7:55               ` Thierry Volpiatto
2022-09-27  8:35                 ` Po Lu
2022-09-27 18:33                   ` Stefan Kangas
2022-09-28  0:34                     ` Po Lu
2022-09-27 13:57             ` Stefan Kangas
2022-09-27 15:43               ` Visuwesh
2022-09-27 16:19                 ` Stefan Kangas
2022-09-27 16:39                   ` Thierry Volpiatto
2022-09-27 16:40                   ` Eli Zaretskii
2022-09-27 17:01                     ` Stefan Kangas
2022-09-27 17:14                       ` Eli Zaretskii
2022-09-27 18:02                         ` Make format-spec accept a function as the substitution Stefan Kangas
2022-09-29  6:57                           ` Thierry Volpiatto
2022-09-29 12:36                             ` Stefan Monnier
2022-09-29 12:59                               ` Stefan Kangas
2022-09-29 15:02                               ` Philip Kaludercic
2022-09-29 16:34                                 ` Stefan Kangas
2022-09-29 16:53                                   ` Philip Kaludercic
2022-09-29 17:06                                     ` Stefan Kangas
2022-09-29 16:56                                 ` Stefan Monnier
2022-09-29 15:09                               ` Thierry Volpiatto
2022-09-29 16:34                                 ` Stefan Kangas
2022-09-29 14:16             ` master fe7c015b20: Support XFCE in wallpaper.el Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmmHpeEr_rT24Daa-3D7Q85sy0HeF-P_OcX9Z5ard_hMaw@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=thievol@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).