From: dalanicolai <dalanicolai@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs Devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] add epub support to doc-view
Date: Sat, 29 Jan 2022 18:07:47 +0100 [thread overview]
Message-ID: <CACJP=3nuiVcX_j0+kNaZt-FEWj4eco0oCgTV_SDknzAddJmd1A@mail.gmail.com> (raw)
In-Reply-To: <87lez1maf0.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
Great!
I am checking for compiling errors frequently now, and will try to make
that always.
And handy to know about `M-x submit-emacs-patch` also.
Anyway... thanks for merging!
On Thu, 27 Jan 2022 at 17:05, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> dalanicolai <dalanicolai@gmail.com> writes:
>
> > Just a gentle reminder, because I am not sure if you have seen this.
> > I think this patch is more or less ready for merging (all previous
> feedback
> > has been processed, and it is only a small patch).
>
> Thanks; pushed to Emacs 29 (with some changes -- there were
> byte-compilation warnings due to the ordering of macros and variables).
>
> And it's usually safer to submit patches with `M-x submit-emacs-patch'
> so that the patches land in the bug tracker. Patches posted to
> emacs-devel have an unfortunate tendency to get lost.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
>
[-- Attachment #2: Type: text/html, Size: 1516 bytes --]
prev parent reply other threads:[~2022-01-29 17:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 2:20 [PATCH] add epub support to doc-view dalanicolai
2022-01-11 2:32 ` Po Lu
2022-01-11 9:34 ` dalanicolai
2022-01-11 9:50 ` Tassilo Horn
2022-01-11 10:04 ` dalanicolai
2022-01-11 10:08 ` dalanicolai
2022-01-11 10:15 ` Robert Pluim
2022-01-11 9:59 ` Robert Pluim
2022-01-11 10:09 ` dalanicolai
2022-01-11 2:48 ` Stefan Monnier
2022-01-11 3:30 ` Stefan Kangas
2022-01-11 10:01 ` dalanicolai
2022-01-11 10:16 ` Robert Pluim
2022-01-13 9:14 ` dalanicolai
2022-01-11 9:59 ` dalanicolai
2022-01-11 10:13 ` dalanicolai
2022-01-11 14:39 ` Stefan Monnier
2022-01-13 9:25 ` dalanicolai
2022-01-14 16:15 ` dalanicolai
2022-01-14 20:02 ` dalanicolai
2022-01-26 20:28 ` dalanicolai
2022-01-27 16:05 ` Lars Ingebrigtsen
2022-01-27 21:09 ` Iñigo Serna
2022-01-28 13:47 ` Lars Ingebrigtsen
2022-01-28 19:51 ` Iñigo Serna
2022-01-29 17:07 ` dalanicolai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACJP=3nuiVcX_j0+kNaZt-FEWj4eco0oCgTV_SDknzAddJmd1A@mail.gmail.com' \
--to=dalanicolai@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).