From: "Iñigo Serna" <inigoserna@gmx.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: dalanicolai <dalanicolai@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: [PATCH] add epub support to doc-view
Date: Thu, 27 Jan 2022 22:09:23 +0100 [thread overview]
Message-ID: <87mtjg2890.fsf@gmx.com> (raw)
In-Reply-To: <87lez1maf0.fsf@gnus.org>
Hi,
I'm afraid this chunk is missing from the commit, so opening epub
or fb2
fails with this cryptic error message:
DocView: process pdf/ps->png changed status to exited
abnormally with code 1.
@@ -1189,7 +1216,7 @@ doc-view-pdf/ps->png
"Convert PDF-PS to PNG asynchronously."
(funcall
(pcase doc-view-doc-type
- ('pdf doc-view-pdf->png-converter-function)
+ ((or 'pdf 'epub 'cbz 'fb2 'xps 'oxps)
doc-view-pdf->png-converter-function)
('djvu #'doc-view-djvu->tiff-converter-ddjvu)
(_ #'doc-view-ps->png-converter-ghostscript))
pdf-ps png nil
Thanks,
Iñigo
On 27 January 2022 at 17:05 +01, Lars Ingebrigtsen
<larsi@gnus.org> wrote:
> dalanicolai <dalanicolai@gmail.com> writes:
>
>> Just a gentle reminder, because I am not sure if you have seen
>> this.
>> I think this patch is more or less ready for merging (all
>> previous feedback
>> has been processed, and it is only a small patch).
>
> Thanks; pushed to Emacs 29 (with some changes -- there were
> byte-compilation warnings due to the ordering of macros and
> variables).
>
> And it's usually safer to submit patches with `M-x
> submit-emacs-patch'
> so that the patches land in the bug tracker. Patches posted to
> emacs-devel have an unfortunate tendency to get lost.
next prev parent reply other threads:[~2022-01-27 21:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 2:20 [PATCH] add epub support to doc-view dalanicolai
2022-01-11 2:32 ` Po Lu
2022-01-11 9:34 ` dalanicolai
2022-01-11 9:50 ` Tassilo Horn
2022-01-11 10:04 ` dalanicolai
2022-01-11 10:08 ` dalanicolai
2022-01-11 10:15 ` Robert Pluim
2022-01-11 9:59 ` Robert Pluim
2022-01-11 10:09 ` dalanicolai
2022-01-11 2:48 ` Stefan Monnier
2022-01-11 3:30 ` Stefan Kangas
2022-01-11 10:01 ` dalanicolai
2022-01-11 10:16 ` Robert Pluim
2022-01-13 9:14 ` dalanicolai
2022-01-11 9:59 ` dalanicolai
2022-01-11 10:13 ` dalanicolai
2022-01-11 14:39 ` Stefan Monnier
2022-01-13 9:25 ` dalanicolai
2022-01-14 16:15 ` dalanicolai
2022-01-14 20:02 ` dalanicolai
2022-01-26 20:28 ` dalanicolai
2022-01-27 16:05 ` Lars Ingebrigtsen
2022-01-27 21:09 ` Iñigo Serna [this message]
2022-01-28 13:47 ` Lars Ingebrigtsen
2022-01-28 19:51 ` Iñigo Serna
2022-01-29 17:07 ` dalanicolai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtjg2890.fsf@gmx.com \
--to=inigoserna@gmx.com \
--cc=dalanicolai@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).