From: Daniel Pittman <slippycheeze@google.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations.
Date: Tue, 2 Apr 2019 09:34:57 +0000 [thread overview]
Message-ID: <CAC45yQvOAV0f-GvjmaeE35W8dL9XDDVCV7q1Z+Own+393z4WQA@mail.gmail.com> (raw)
In-Reply-To: <87bm1tr4sk.fsf@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
On Fri, Mar 29, 2019 at 5:03 PM Michael Albinus <michael.albinus@gmx.de>
wrote:
> Daniel Pittman <slippycheeze@google.com> writes:
> > The most interesting part is at the very start, where my `revert-file
> > ` operation on a remote file triggers a `vc-refresh-state`, which ends
> > up causing `tramp-send-string` to run `process-send-string`, and then
> > a timer fires that drives the "deferred" third party library [1] to
> > move on to running a background command, using the timeout(1) and p4
> > (1) binaries to grab some state information.
>
> Yes. Tramp fights indeed with timers, and so I have disabled timers in
> tramp-accept-process-output already. Maybe we shall do the same in
> tramp-send-string? Would the following patch help?
In brief testing – 100 percent reproducible error, but only one instance –
this patch did fix the problem. I haven't tried to provoke a non-local
exit from anything contained within, or anything like that, since you
obviously omitted the code for that in this test patch.
So, yeah, I think that is sufficient.
[-- Attachment #2: Type: text/html, Size: 1498 bytes --]
next prev parent reply other threads:[~2019-04-02 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 15:38 TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations Daniel Pittman
2019-03-27 15:55 ` Michael Albinus
2019-03-27 16:22 ` Daniel Pittman
2019-03-27 17:49 ` Michael Albinus
2019-03-29 12:36 ` Daniel Pittman
2019-03-29 17:03 ` Michael Albinus
2019-04-02 9:34 ` Daniel Pittman [this message]
2019-04-02 13:18 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC45yQvOAV0f-GvjmaeE35W8dL9XDDVCV7q1Z+Own+393z4WQA@mail.gmail.com \
--to=slippycheeze@google.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).