From: Michael Albinus <michael.albinus@gmx.de>
To: Daniel Pittman <slippycheeze@google.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations.
Date: Wed, 27 Mar 2019 18:49:41 +0100 [thread overview]
Message-ID: <8736n8i4wa.fsf@gmx.de> (raw)
In-Reply-To: <CAC45yQv-hP-B0QgooQ2x++VDO8YpiZuKJC+fCrwYjkQEyrKk9Q@mail.gmail.com> (Daniel Pittman's message of "Wed, 27 Mar 2019 16:22:58 +0000")
Daniel Pittman <slippycheeze@google.com> writes:
Hi Daniel,
> My best guess is that we should disable that optimization for now, and
> if desirable, reapproach it.
Before doing this, I'd like to check whether there is a simple solution.
> One possibly functional strategy, but that I have not considered all
> possible angles of, might be to fetch the path and then if `(not
> (tramp-file-name-p ...))` dispatch to the original file name handlers.
> I think that would absolutely work as long as none of those callbacks
> interacted with a tramp path at all, and it .... might, but probably
> wouldn't, if they did.
In your initial message you've said, that the problem happened inside
tramp-vc-file-name-handler. Is this always the case? If yes, I could
simply catch errors inside this function, and in case of, throw away all
results. This would fall back to the non-optimized solution by default.
Since I cannot reproduce the problem (yet), do you have a backtrace?
Setting tramp-verbose to 10 would suffice, because with this verbosity,
any error triggers Tramp to write the backtrace into the debug buffer.
> Historically, I attached a tramp operation to copy the generated
> server(-start) key to a remote tramp path, since I used a TCP
> listener, ssh forwarding, and that shared secret to allow remote
> emacsclient to work. That could have triggered at any point after
> tramp reconnected, as it advised a fairly low level tramp function.
> I'm not sure how common (or cared about) that sort of nastly hack is,
> but I'm not confident that more legitimate ways to do the same could
> be in use in the wild.
Sorry, I don't follow here :-( How is this related?
Best regards, Michael.
next prev parent reply other threads:[~2019-03-27 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 15:38 TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations Daniel Pittman
2019-03-27 15:55 ` Michael Albinus
2019-03-27 16:22 ` Daniel Pittman
2019-03-27 17:49 ` Michael Albinus [this message]
2019-03-29 12:36 ` Daniel Pittman
2019-03-29 17:03 ` Michael Albinus
2019-04-02 9:34 ` Daniel Pittman
2019-04-02 13:18 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736n8i4wa.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=slippycheeze@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).