From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Pittman Newsgroups: gmane.emacs.devel Subject: Re: TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations. Date: Tue, 2 Apr 2019 09:34:57 +0000 Message-ID: References: <87bm1wmhw6.fsf@gmx.de> <8736n8i4wa.fsf@gmx.de> <87bm1tr4sk.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c6e640058588dbd0" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="124563"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 02 11:36:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBFqU-000WIW-7b for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 11:36:42 +0200 Original-Received: from localhost ([127.0.0.1]:51086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBFqT-0003vd-2m for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 05:36:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBFpY-0003qj-GG for emacs-devel@gnu.org; Tue, 02 Apr 2019 05:35:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBFpV-00058M-MO for emacs-devel@gnu.org; Tue, 02 Apr 2019 05:35:43 -0400 Original-Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]:37728) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBFpR-0004uf-N6 for emacs-devel@gnu.org; Tue, 02 Apr 2019 05:35:40 -0400 Original-Received: by mail-io1-xd31.google.com with SMTP id x7so10336410ioh.4 for ; Tue, 02 Apr 2019 02:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BlHBxW1yT4GtjDSI3Z9TDGGLJMjt44x0WqL2XBARaV4=; b=ZhpG9FwSQTYNBvYgP+FUN8FnSRhiSVcIXk6PyGu43PC/my8aQUPj7Xc5r+oiVRG/pO Yghcdrw+K1ILRqzvy0BdxKgmE0xK1eIg81wxESWgAD29oQ3tyJs/sYDtJHcbegy34Bad 9BFibMdK219q61PneuRpk+lkgunKWapbZ1Z8OH6jR6n08KUJO1t8DW7kHZHSwYcI0M+5 xgpYIP8YSWerdxMbOjQ10X1J+W5zzMNxypv8avhsXZah8lmL+JLX6olU/hTuBUbJi44r VShxqP+2tmBEH/tmc4xRlR29Xe3as/lhX7kGwypSS5K9UG5RClaM95dqytlSZBEc8dM+ rGAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BlHBxW1yT4GtjDSI3Z9TDGGLJMjt44x0WqL2XBARaV4=; b=IH+X9GC3iHujOIyK9+7AgXXUDBiQj5BJ674KeA4sWLh3jmyxxDqeJUSk87B/hPzQmV B7KORirZM9o3jWCjxDfKpWTpZ4ZvuyWNrnhL2ZjHcQTi2gjKBdC/pFodNw9OtJX5xMjc yUrT6j9cSOYv/4V+9wlJ+b3Bo0yKBlTWIxunDxdx7Y4WImTfdvQOZnU9QwpM9TLw0t9Y luw8DLTU0zgAIu1FgTQVaIuVmurlP/DcSQ3TZfs+2R1rT2YCcEaUx85XNTL50nrr9ZcN 3c/Wte8Mb6iX5YeBhn2yxyaxiuIh0cC4ONEvWTIyjCwmp0yeeaalVt9Yz9kzB4PQUBVs LdNw== X-Gm-Message-State: APjAAAUJQlAgNqRnIpmqI78EypB19WVQMZpxjrHaVYKY37euREFx7r2Y GJiYrpHm5NCE4I6GZHzojfOFeUd2dlydjr18qqIg+Q== X-Google-Smtp-Source: APXvYqzhTTWInnrLxumkLYsAZMt2j0rB4e16Tt/MmbXq0VQMmmb4UNJ8ahMUCmTmkYU+rIkxFQ6SGcdByAt6ETk8egI= X-Received: by 2002:a6b:91c6:: with SMTP id t189mr49661424iod.247.1554197732808; Tue, 02 Apr 2019 02:35:32 -0700 (PDT) In-Reply-To: <87bm1tr4sk.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d31 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234857 Archived-At: --000000000000c6e640058588dbd0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 29, 2019 at 5:03 PM Michael Albinus wrote: > Daniel Pittman writes: > > The most interesting part is at the very start, where my `revert-file > > ` operation on a remote file triggers a `vc-refresh-state`, which ends > > up causing `tramp-send-string` to run `process-send-string`, and then > > a timer fires that drives the "deferred" third party library [1] to > > move on to running a background command, using the timeout(1) and p4 > > (1) binaries to grab some state information. > > Yes. Tramp fights indeed with timers, and so I have disabled timers in > tramp-accept-process-output already. Maybe we shall do the same in > tramp-send-string? Would the following patch help? In brief testing =E2=80=93 100 percent reproducible error, but only one ins= tance =E2=80=93 this patch did fix the problem. I haven't tried to provoke a non-local exit from anything contained within, or anything like that, since you obviously omitted the code for that in this test patch. So, yeah, I think that is sufficient. --000000000000c6e640058588dbd0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Mar 29, 2019 at 5:03 PM Michael A= lbinus <michael.albinus@gmx.de= > wrote:
Daniel Pittman <slippycheeze@google.com> writes:
= > The most interesting part is at the very start, where my `revert-file<= br> > ` operation on a remote file triggers a `vc-refresh-state`, which ends=
> up causing `tramp-send-string` to run `process-send-string`, and then<= br> > a timer fires that drives the "deferred" third party library= [1] to
> move on to running a background command, using the timeout(1) and p4 > (1) binaries to grab some state information.

Yes. Tramp fights indeed with timers, and so I have disabled timers in
tramp-accept-process-output already. Maybe we shall do the same in
tramp-send-string? Would the following patch help?

In brief testing =E2=80=93 100 percent reproducible error, but only= one instance =E2=80=93 this patch did fix the problem.=C2=A0 I haven't= tried to provoke a non-local exit from anything contained within, or anyth= ing like that, since you obviously omitted the code for that in this test p= atch.

So, yeah, I think that is sufficient.
<= /div>
--000000000000c6e640058588dbd0--