From: Randy Taylor <dev@rjt.dev>
To: Theodor Thornhill <theo@thornhill.no>
Cc: Yuan Fu <casouri@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use
Date: Tue, 15 Nov 2022 00:47:41 +0000 [thread overview]
Message-ID: <9T55ZBXi9h5N4O9RqM4jvYMI2VgkGFWfTHQ5T8gS-_JD95YP04nzWFULyXHYhi86D8AtCw6cXvPw5bHZrTA-2l45yGwY1gFT61A2tLrhVok=@rjt.dev> (raw)
In-Reply-To: <87h6z1l4ve.fsf@thornhill.no>
Looks like my bug finally got created (Bug#59268) so we can continue the discussion there.
Will reply to what's been said so far below.
On Monday, November 14th, 2022 at 14:20, Theodor Thornhill <theo@thornhill.no> wrote:
>
> Are you sure we cover most of the stuff that was covered in the old
> style? I see it is different visually, but that's likely the new faces
> are without any color, right?
I think so, at least I don't notice anything wrong (the old style was actually missing some things).
Indeed, most of the new faces are without any colour. Property and escape-sequence are the only ones
that have any, and they inherit.
Do you have any specific examples?
>
> I think you should add similar changes to all the new modes:
>
> - ts-mode
> - json-ts-mode
> - css-ts-mode
> - java-ts-mode
> - js-mode
>
> If you have time and energy, of course :-)
>
I plan to. Hopefully this week and weekend.
next prev parent reply other threads:[~2022-11-15 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 19:20 [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use Theodor Thornhill
2022-11-15 0:47 ` Randy Taylor [this message]
2022-11-15 10:25 ` Theodor Thornhill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='9T55ZBXi9h5N4O9RqM4jvYMI2VgkGFWfTHQ5T8gS-_JD95YP04nzWFULyXHYhi86D8AtCw6cXvPw5bHZrTA-2l45yGwY1gFT61A2tLrhVok=@rjt.dev' \
--to=dev@rjt.dev \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).