From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use Date: Tue, 15 Nov 2022 00:47:41 +0000 Message-ID: <9T55ZBXi9h5N4O9RqM4jvYMI2VgkGFWfTHQ5T8gS-_JD95YP04nzWFULyXHYhi86D8AtCw6cXvPw5bHZrTA-2l45yGwY1gFT61A2tLrhVok=@rjt.dev> References: <87h6z1l4ve.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7890"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , emacs-devel@gnu.org To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 15 02:03:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oukM5-0001qG-Ql for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Nov 2022 02:03:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouk7O-0000HB-GI; Mon, 14 Nov 2022 19:48:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouk7C-0000Do-Oz for emacs-devel@gnu.org; Mon, 14 Nov 2022 19:47:52 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouk79-0005SV-S9 for emacs-devel@gnu.org; Mon, 14 Nov 2022 19:47:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1668473263; x=1668732463; bh=hKb+0us9qGKz753ix1GaBHul2SZco3KBJLw9UABaaq4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=jtTwQT19o0XJMMOyBFUkQzD9nbaPt9AhVT7tiV8Hk5CkBtWZXvyrkCuPn0jPmZCmg g48BGnRIki2NLWjiNUv19epiHlH7bcOPbBGsLe+CmXJmJki8/b0zBhtxzlbO573jtd ibQpIw8qBvUZnZ54kF9z+VtABZZwC1KVuB9xLQviuxyXj/cmjlCKfEVmoZkXwqOOzh K5Atytq8hLkLAmLxUJo8tQTco2HXzxJlQvYhXgRfxGiq5ek8Fn/Vxw1CFs3oN7Fui0 mgIwUPIN+z+aAtDPqS61Woq6VOm2VUZL9el8BNS5QxCtfOWnVIPrNoT3NJ55NV+htc vdVThDgWBrw1A== In-Reply-To: <87h6z1l4ve.fsf@thornhill.no> Feedback-ID: 44397038:user:proton Received-SPF: pass client-ip=185.70.43.17; envelope-from=dev@rjt.dev; helo=mail-4317.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299807 Archived-At: Looks like my bug finally got created (Bug#59268) so we can continue the di= scussion there. Will reply to what's been said so far below. On Monday, November 14th, 2022 at 14:20, Theodor Thornhill wrote: >=20 > Are you sure we cover most of the stuff that was covered in the old > style? I see it is different visually, but that's likely the new faces > are without any color, right? I think so, at least I don't notice anything wrong (the old style was actua= lly missing some things). Indeed, most of the new faces are without any colour. Property and escape-s= equence are the only ones that have any, and they inherit. Do you have any specific examples? >=20 > I think you should add similar changes to all the new modes: >=20 > - ts-mode > - json-ts-mode > - css-ts-mode > - java-ts-mode > - js-mode >=20 > If you have time and energy, of course :-) > I plan to. Hopefully this week and weekend.