From: Theodor Thornhill <theo@thornhill.no>
To: Randy Taylor <dev@rjt.dev>, Yuan Fu <casouri@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use
Date: Mon, 14 Nov 2022 20:20:53 +0100 [thread overview]
Message-ID: <87h6z1l4ve.fsf@thornhill.no> (raw)
(adding back in emacs-devel)
Randy Taylor <dev@rjt.dev> writes:
> Hey guys,
>
> Seems like the mailing lists are down from what I can tell, so just
> sending the patch I sent out yesterday in case either of you wanted to
> take a look. Not sure how long the lists will be down for (or even
> what's going on).
>
> BTW I think it would be a good idea to figure out some guidelines for
> the tree-sitter features (and write them down somewhere) - some that
> are applicable to as many languages as possible, and preferably as
> small as possible. That way we can have consistent implementations,
> and languages can deviate where they may need to. I will think about
> composing a list of what we may want.
>
I think that's smart, but I envision we will diverge in any case, hehe.
> Here's what I said in the email:
> I'm just submitting C/C++ and Python for now since some of the other files are
> a little more volatile currently (there are some patches in progress).
>
I like it!
Are you sure we cover most of the stuff that was covered in the old
style? I see it is different visually, but that's likely the new faces
are without any color, right?
I think you should add similar changes to all the new modes:
- ts-mode
- json-ts-mode
- css-ts-mode
- java-ts-mode
- js-mode
If you have time and energy, of course :-)
Theo
next reply other threads:[~2022-11-14 19:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 19:20 Theodor Thornhill [this message]
2022-11-15 0:47 ` [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use Randy Taylor
2022-11-15 10:25 ` Theodor Thornhill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6z1l4ve.fsf@thornhill.no \
--to=theo@thornhill.no \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).