From: David Reitter <david.reitter@gmail.com>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: menu-bar: disable items when no frame visible
Date: Sat, 24 Dec 2005 13:15:28 +0100 [thread overview]
Message-ID: <9F80EEEC-3EDF-47B5-9837-2091650A8C5D@gmail.com> (raw)
In-Reply-To: <87y82b7evb.fsf@jurta.org>
On 23 Dec 2005, at 21:43, Juri Linkov wrote:
> 1. What is the purpose of adding the condition `enable-recursive-
> minibuffers'
> to `:enable' of "Visit New File..." and "Open File..."? If to allow
> calling `find-file' in the minibuffer then this doesn't work anyway.
> It gives an error after selecting "Open File..." and selecting a
> file name
> while point in the minibuffer:
>
> find-file: Cannot switch buffers in minibuffer window
Yes, you're right.
But I would suggest improving find-file to catch the error in switch-
to-buffer and show the buffer in another window in that case, at
least when called interactively.
(This made sense in my own setup because I have advised switch-to-
buffer to show most buffers in a new frame, so I don't usually get
that error.)
> 2. Why keymap variables are replaced with their values at the moment
> of adding a menu item? I.e. what changes like the following achieve?
>
> (define-key menu-bar-edit-menu [bookmark]
> - '(menu-item "Bookmarks" menu-bar-bookmark-map
> + `(menu-item "Bookmarks" ,menu-bar-bookmark-map
> :help "Record positions and jump between them"))
Thanks for pointing this out, maybe that's a bug in the patch. Let's
leave this particular change out.
next prev parent reply other threads:[~2005-12-24 12:15 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-10 15:57 menu-bar: disable items when no frame visible David Reitter
2005-11-10 16:03 ` David Reitter
2005-11-10 21:12 ` David Reitter
2005-11-12 3:38 ` Richard M. Stallman
2005-11-12 7:11 ` Eli Zaretskii
2005-11-12 21:21 ` Richard M. Stallman
2005-11-12 22:44 ` Eli Zaretskii
2005-11-28 0:21 ` David Reitter
2005-11-28 5:32 ` Eli Zaretskii
2005-11-28 20:23 ` Juri Linkov
2005-11-28 21:00 ` Richard M. Stallman
2005-11-28 22:20 ` David Reitter
2005-11-28 22:46 ` Jason Rumney
2005-11-29 10:32 ` Reiner Steib
2005-11-29 21:48 ` Richard M. Stallman
2005-12-06 0:54 ` Juri Linkov
2005-12-06 16:43 ` Richard M. Stallman
2005-12-07 0:45 ` Juri Linkov
2005-12-07 22:58 ` Richard M. Stallman
2005-12-12 8:23 ` Jan D.
2005-12-12 21:14 ` Eli Zaretskii
2005-12-13 7:19 ` Jan Djärv
2005-12-13 20:24 ` Eli Zaretskii
2005-12-14 17:03 ` Juri Linkov
2005-12-14 19:25 ` Eli Zaretskii
2005-12-16 9:04 ` Juri Linkov
2005-12-16 11:29 ` Eli Zaretskii
2005-12-16 12:55 ` Juri Linkov
2005-12-16 13:14 ` Eli Zaretskii
2005-12-16 14:27 ` Juri Linkov
2005-12-16 15:24 ` Eli Zaretskii
2005-12-17 10:54 ` Juri Linkov
2005-12-14 21:25 ` Drew Adams
2005-12-15 4:33 ` Eli Zaretskii
2005-12-13 3:15 ` Richard M. Stallman
2005-12-16 9:05 ` Juri Linkov
2005-12-16 17:40 ` Jan Djärv
2005-12-17 10:47 ` Juri Linkov
2005-12-20 21:55 ` Juri Linkov
2005-12-23 20:43 ` Juri Linkov
2005-12-24 12:15 ` David Reitter [this message]
2005-12-24 20:07 ` Juri Linkov
2005-12-24 22:59 ` David Reitter
2005-12-25 16:54 ` Stefan Monnier
2005-12-25 2:51 ` Richard M. Stallman
2005-12-25 6:44 ` Eli Zaretskii
2005-12-26 2:19 ` Richard M. Stallman
2005-12-26 5:06 ` Eli Zaretskii
2005-12-25 9:54 ` David Reitter
2005-12-26 2:19 ` Richard M. Stallman
2005-12-25 16:58 ` Stefan Monnier
[not found] ` <87x6v29lvv.fsf-monnier+emacs@gnu.org>
2005-12-26 2:20 ` Richard M. Stallman
2005-12-26 16:02 ` Stefan Monnier
2005-12-26 21:56 ` Richard M. Stallman
2005-12-27 19:01 ` Juri Linkov
2005-12-27 19:55 ` Stefan Monnier
2005-12-24 16:32 ` Richard M. Stallman
2005-12-24 20:12 ` Juri Linkov
2005-11-10 19:34 ` Eli Zaretskii
2005-11-10 19:39 ` David Reitter
2005-11-11 8:33 ` Eli Zaretskii
2005-11-12 3:38 ` Richard M. Stallman
2005-11-28 20:23 ` Juri Linkov
2005-11-28 22:17 ` David Reitter
2005-11-28 22:44 ` Juri Linkov
2005-11-29 0:08 ` David Reitter
2005-11-29 9:03 ` Juri Linkov
2005-11-29 9:02 ` Juri Linkov
2005-11-29 3:10 ` Richard M. Stallman
2005-11-29 9:01 ` Juri Linkov
2005-11-29 21:47 ` Richard M. Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F80EEEC-3EDF-47B5-9837-2091650A8C5D@gmail.com \
--to=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).