From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: menu-bar: disable items when no frame visible Date: Sat, 24 Dec 2005 13:15:28 +0100 Message-ID: <9F80EEEC-3EDF-47B5-9837-2091650A8C5D@gmail.com> References: <708F3D2D-A87C-4F80-BC27-171D82653F4D@gmail.com> <069BF3EB-C5E4-4042-91E9-0DFB37C58E99@gmail.com> <87u0d3cu9y.fsf@jurta.org> <87y82b7evb.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v746.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1135428798 16746 80.91.229.2 (24 Dec 2005 12:53:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 24 Dec 2005 12:53:18 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 24 13:53:16 2005 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Eq8tg-0001DI-21 for ged-emacs-devel@m.gmane.org; Sat, 24 Dec 2005 13:53:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Eq8um-0003yN-Aa for ged-emacs-devel@m.gmane.org; Sat, 24 Dec 2005 07:54:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Eq8Mj-0002NM-P0 for emacs-devel@gnu.org; Sat, 24 Dec 2005 07:19:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Eq8Mf-0002Lo-Bo for emacs-devel@gnu.org; Sat, 24 Dec 2005 07:19:12 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Eq8KQ-0001lX-0U for emacs-devel@gnu.org; Sat, 24 Dec 2005 07:16:50 -0500 Original-Received: from [66.249.92.202] (helo=uproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Eq8Js-0005X3-5E for emacs-devel@gnu.org; Sat, 24 Dec 2005 07:16:16 -0500 Original-Received: by uproxy.gmail.com with SMTP id u2so243132uge for ; Sat, 24 Dec 2005 04:15:39 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=r/55qablc7KFQ7xf0eovYfRUjnkYq45YVDjzlSz0oQX8yYvfDa5ZWFkJ28FXozfPj0x6x/5pfDqGOXn0vXhdPxOHqDgyXlvvSWWG/jixj1Tww4w5xAJI0Ri650o12KKJbQb+gr/wnNOULhlEX6DwyM/f3Qfrop3SvZL9kqUDoxk= Original-Received: by 10.66.255.3 with SMTP id c3mr1225508ugi; Sat, 24 Dec 2005 04:15:38 -0800 (PST) Original-Received: from ?192.168.178.111? ( [84.169.137.55]) by mx.gmail.com with ESMTP id q40sm2093086ugc.2005.12.24.04.15.34; Sat, 24 Dec 2005 04:15:38 -0800 (PST) In-Reply-To: <87y82b7evb.fsf@jurta.org> Original-To: Juri Linkov X-Mailer: Apple Mail (2.746.2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48301 Archived-At: On 23 Dec 2005, at 21:43, Juri Linkov wrote: > 1. What is the purpose of adding the condition `enable-recursive- > minibuffers' > to `:enable' of "Visit New File..." and "Open File..."? If to allow > calling `find-file' in the minibuffer then this doesn't work anyway. > It gives an error after selecting "Open File..." and selecting a > file name > while point in the minibuffer: > > find-file: Cannot switch buffers in minibuffer window Yes, you're right. But I would suggest improving find-file to catch the error in switch- to-buffer and show the buffer in another window in that case, at least when called interactively. (This made sense in my own setup because I have advised switch-to- buffer to show most buffers in a new frame, so I don't usually get that error.) > 2. Why keymap variables are replaced with their values at the moment > of adding a menu item? I.e. what changes like the following achieve? > > (define-key menu-bar-edit-menu [bookmark] > - '(menu-item "Bookmarks" menu-bar-bookmark-map > + `(menu-item "Bookmarks" ,menu-bar-bookmark-map > :help "Record positions and jump between them")) Thanks for pointing this out, maybe that's a bug in the patch. Let's leave this particular change out.