unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Herman, Geza" <geza.herman@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Rendering performace vs. line-spacing
Date: Fri, 8 Jan 2021 17:04:44 +0100	[thread overview]
Message-ID: <953e42e4-40bc-6471-c8dc-67d429e0ccab@gmail.com> (raw)
In-Reply-To: <83v9c7ig7r.fsf@gnu.org>



On 2021-01-08 16:46, Eli Zaretskii wrote:
>> Cc: emacs-devel@gnu.org
>> From: "Herman, Geza" <geza.herman@gmail.com>
>> Date: Fri, 8 Jan 2021 16:38:10 +0100
>>
>> I disabled redrawing caused by overlapping by commenting out the line
>> which sets the "row->overlapping_p" flag (xdisp.c:21752), and the
>> problem is gone away. But my fonts are clipped (not a surprise). But, it
>> fixed the consolas case as well, and I don't see any clipping with this
>> font. Maybe overlapping detection is too strict (I mean, emacs considers
>> cases overlapping which are close to overlapping, but they aren't)? Or
>> maybe I just don't notice the clipping.
> It could be that in the case of Consolas the overlapping doesn't
> actually happen, but some metrics we get from the font tell us they
> are.  Or maybe they do happen, but only when very few characters from
> the font are used.  Or maybe this also depends on the font backend,
> like whether you build with or without Cairo.
>
> This calls for some font expert(s) to study the Consolas case and see
> why the problem happens there.  Perhaps we could speed up at least
> that case, I don't know.
Okay, thanks for the help! I adjusted my font's ascent/descent, and now 
I don't see any clipping with this font either (for the record, I'm 
using Cairo).

If I have the time, I may have a look at this part of emacs's code and 
try to understand what's going on exactly.



      reply	other threads:[~2021-01-08 16:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 11:34 Rendering performace vs. line-spacing Herman, Géza
2021-01-08 12:22 ` Eli Zaretskii
2021-01-08 13:46   ` Herman, Geza
2021-01-08 14:35     ` Eli Zaretskii
2021-01-08 15:38       ` Herman, Geza
2021-01-08 15:46         ` Eli Zaretskii
2021-01-08 16:04           ` Herman, Geza [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=953e42e4-40bc-6471-c8dc-67d429e0ccab@gmail.com \
    --to=geza.herman@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).