From: "Herman, Geza" <geza.herman@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Rendering performace vs. line-spacing
Date: Fri, 8 Jan 2021 16:38:10 +0100 [thread overview]
Message-ID: <07831f4d-c03b-f8cf-e4f8-2561b214c911@gmail.com> (raw)
In-Reply-To: <83zh1jijij.fsf@gnu.org>
On 2021-01-08 15:35, Eli Zaretskii wrote:
> If screen lines overlap with the offending font, then the difference
> could be justified, because redrawing one screen line would require
> redrawing the two adjacent screen lines. I'm a bit surprised by the
> large performance hit, though, so maybe it's worth looking at the code
> which gets run in the slow case, to see maybe some unnecessary work we
> are doing in that case.
>
> Do you have very wide windows, per chance? Does the problem becomes
> smaller if you make your frames and windows narrower?
Yes, my full screen emacs has a width of ~270. Sometimes I use this as a
full screen window, sometimes I split it into two with
split-window-horizontally.
And yes, the problem becomes smaller if I make the window narrower, or
if the screen contains less characters. This problem is most visible at
a particular part of my code which contains a larger table, with long
lines (~160).
I disabled redrawing caused by overlapping by commenting out the line
which sets the "row->overlapping_p" flag (xdisp.c:21752), and the
problem is gone away. But my fonts are clipped (not a surprise). But, it
fixed the consolas case as well, and I don't see any clipping with this
font. Maybe overlapping detection is too strict (I mean, emacs considers
cases overlapping which are close to overlapping, but they aren't)? Or
maybe I just don't notice the clipping.
next prev parent reply other threads:[~2021-01-08 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 11:34 Rendering performace vs. line-spacing Herman, Géza
2021-01-08 12:22 ` Eli Zaretskii
2021-01-08 13:46 ` Herman, Geza
2021-01-08 14:35 ` Eli Zaretskii
2021-01-08 15:38 ` Herman, Geza [this message]
2021-01-08 15:46 ` Eli Zaretskii
2021-01-08 16:04 ` Herman, Geza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07831f4d-c03b-f8cf-e4f8-2561b214c911@gmail.com \
--to=geza.herman@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).