From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Herman, Geza" Newsgroups: gmane.emacs.devel Subject: Re: Rendering performace vs. line-spacing Date: Fri, 8 Jan 2021 17:04:44 +0100 Message-ID: <953e42e4-40bc-6471-c8dc-67d429e0ccab@gmail.com> References: <5f7dd7c3-ec7d-ffd5-76af-1a5ee5177d07@gmail.com> <83a6tjk485.fsf@gnu.org> <47ad132e-a6e4-6f10-e952-c490bf93c71e@gmail.com> <83zh1jijij.fsf@gnu.org> <07831f4d-c03b-f8cf-e4f8-2561b214c911@gmail.com> <83v9c7ig7r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20123"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 08 17:08:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxuJP-00053k-ED for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jan 2021 17:08:27 +0100 Original-Received: from localhost ([::1]:39178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxuJO-0002W6-Bg for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jan 2021 11:08:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxuFt-0007pC-RY for emacs-devel@gnu.org; Fri, 08 Jan 2021 11:04:49 -0500 Original-Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:39485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxuFr-0004WE-Vq; Fri, 08 Jan 2021 11:04:49 -0500 Original-Received: by mail-ej1-x62e.google.com with SMTP id n26so15169214eju.6; Fri, 08 Jan 2021 08:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=5OtvLxs8I9wW+6pnRyiojquv0rqTjyZ2QCrU5O7p3qM=; b=CDaUZG3S8gqDG7/V6F+w38pWIgZFs4+JcujbiTLA4xF0wuo1JJpT+eYSPiWRM+ba+y 5OvoUqvDD+GgIMqHnLpoFRH2/uskoKsPr2jNijKqr+MHJ6eXc+O9z2UaTNB+XUxfRhAj mtn+J1Y5a2cGdKeNlN5dnTTHkZJu3wxHz5QPBkwSLUV7U5Z2ub7csXue4TkE/dDtwZa4 icvDEcxxMnK2E19S1/6p6k87r3IbRRA43lsCneATtTluGmUZJfcsM+ZaPpaIJj6BVnyN RnYeHXzj4P846oKrBmzvWrrEHwWqUJP8eFMOamYGhhpBeoTfEnblDliL3AiI+E2DmU6n RuTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5OtvLxs8I9wW+6pnRyiojquv0rqTjyZ2QCrU5O7p3qM=; b=iquILMamGfv8J53xHmS21n3xklzEwYQfSnKMTBJhk0bv3cfVB6bI1rSsXUcAawHCaW vyN4iNOqo21ZTBeS8m0M5jXp7gSpp8C9iyHZuMLj9QqeYdWZYCJmfMSCNulknYEXQKoF cNLsEC3m8tgYxaswT22oqGxQCS0iDdyWXUIrEAkED85hNp4Z+JNAqPa2oswJ3DoVVEC/ hyfBXEXTBk7u+lyMy3dUqSNydFolkiuWi1IhQDGkM+duO16Fc5AdFp0lHK+AzcA9XClA mGo2uW1aMXznshXOjhRcUdK4vIPeMexAVPxxzwMuzjK0pbaLB8VonraH0IcHudG6w6ec DLCA== X-Gm-Message-State: AOAM530bsRYeeAQPGKmcPpEwidydlPNeWZk/5AzwVR2IHayWOuy1okPv gNBifDsVmpCkT80LD24JfiExwnVMA4+i4Q== X-Google-Smtp-Source: ABdhPJykWqN+Q+9tRfpPHMEdIH5yZm330hVoZyzK+gGqlJO0gm4+ECfpfX5yuVWNl4sSq0Y4NRQ9Gw== X-Received: by 2002:a17:906:1a4e:: with SMTP id j14mr3008434ejf.507.1610121885902; Fri, 08 Jan 2021 08:04:45 -0800 (PST) Original-Received: from [10.0.50.117] (catv-89-134-149-1.catv.broadband.hu. [89.134.149.1]) by smtp.gmail.com with ESMTPSA id c25sm3632748ejx.39.2021.01.08.08.04.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jan 2021 08:04:45 -0800 (PST) In-Reply-To: <83v9c7ig7r.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=geza.herman@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.241, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262758 Archived-At: On 2021-01-08 16:46, Eli Zaretskii wrote: >> Cc: emacs-devel@gnu.org >> From: "Herman, Geza" >> Date: Fri, 8 Jan 2021 16:38:10 +0100 >> >> I disabled redrawing caused by overlapping by commenting out the line >> which sets the "row->overlapping_p" flag (xdisp.c:21752), and the >> problem is gone away. But my fonts are clipped (not a surprise). But, it >> fixed the consolas case as well, and I don't see any clipping with this >> font. Maybe overlapping detection is too strict (I mean, emacs considers >> cases overlapping which are close to overlapping, but they aren't)? Or >> maybe I just don't notice the clipping. > It could be that in the case of Consolas the overlapping doesn't > actually happen, but some metrics we get from the font tell us they > are. Or maybe they do happen, but only when very few characters from > the font are used. Or maybe this also depends on the font backend, > like whether you build with or without Cairo. > > This calls for some font expert(s) to study the Consolas case and see > why the problem happens there. Perhaps we could speed up at least > that case, I don't know. Okay, thanks for the help! I adjusted my font's ascent/descent, and now I don't see any clipping with this font either (for the record, I'm using Cairo). If I have the time, I may have a look at this part of emacs's code and try to understand what's going on exactly.