Re: Scan of regexps in Emacs (March 17)

["Mattias Engdegård" <mattiase@acm.org>]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

3 apr. 2019 kl. 00.08 skrev Paul Eggert <eggert@cs.ucla.edu>:
> 
> On 4/2/19 7:15 AM, Mattias Engdegård wrote:
>> where does a user go to understand extant regexps?
> 
> A user that *really* wants to know can go read the source code and get
> confused, just like I did. :-)
> 
> But I think it's better if the documentation doesn't say what happens.
> If you prefer that the documentation explicitly say that it doesn't say
> what happens, I guess that would be OK too (what sort of wording would
> you like, though?).

I was mostly thinking about regexps like "^***" which do occur in actual code (by mistake), and are almost but not quite explained in the manual. But perhaps some knowledge is better hidden.

>> I've attached the ones found by a modified relint/xr, in case you are interested.
> 
> Sure! Fixed in the attached patch.

Thank you, it looks fine to me. Some tool improvements uncovered more oddities; log attached.


[-- Attachment #2: relint.log --]
[-- Type: application/octet-stream, Size: 1083 bytes --]

;; -*- compilation -*-
lisp/net/tramp.el:2811:30: `skip-regexp' cannot be used for arguments to `skip-chars-forward'
lisp/progmodes/sh-script.el:2909:37: In call to skip-chars-forward: Suspect skip set framed in `[...]' (pos 0)
  "[a-z0-9]*?"
   ^
lisp/progmodes/verilog-mode.el:14269:38: `sig-re' cannot be used for arguments to `skip-chars-backward'
lisp/progmodes/verilog-mode.el:14272:37: `sig-re' cannot be used for arguments to `skip-chars-forward'
lisp/vc/log-edit.el:353:10: In call to re-search-forward: Literal `-' not first or last in character alternative (pos 41)
  "^\\([^[:alpha:]]\\|[[:alnum:]-]+[^[:alnum:]-:]\\)"
   ...........................................^
lisp/xml.el:721:25: In call to re-search-forward: Literal `-' not first or last in character alternative (pos 24)
  "\\=\"\\([[:space:][:alnum:]-'()+,./:=?;!*#@$_%]*\\)\""
   ...........................^
lisp/xml.el:724:25: In call to re-search-forward: Literal `-' not first or last in character alternative (pos 24)
  "\\='\\([[:space:][:alnum:]-()+,./:=?;!*#@$_%]*\\)'"
   ..........................^