From: "Mattias Engdegård" <mattiase@acm.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Scan of regexps in Emacs (March 17)
Date: Wed, 20 Mar 2019 11:04:50 +0100 [thread overview]
Message-ID: <8FD6CD65-D02A-4DAE-B2D6-8D83F23F3930@acm.org> (raw)
In-Reply-To: <3974269b-6cad-0744-bd1f-66c067f94192@cs.ucla.edu>
20 mars 2019 kl. 02.53 skrev Paul Eggert <eggert@cs.ucla.edu>:
>
> Thanks for proofreading that. I installed the attached to try to fix the problems you noted.
That looks fine. You found more skip-chars-* rubbish to clean up, good! Turn any stone...
> I also fixed a couple of other problems if I happened to run across them. First, the regexp [a-b-c] is ambiguous according to POSIX, and should be avoided. Second, a regexp like [[:alnum:]-z] is also ambiguous for the same reason. Perhaps these regexps currently have a particular behavior in Emacs but it's not documented as far as I know and code should avoid them. Perhaps the trawler could be modified to catch them.
Right, the rules are muddy; they had to be reverse-engineered for xr. I was a bit disappointed not to find any [a-[:alnum:]] anywhere though; that would have been a sight.
I'll see what can be done -- it's always a matter of balance to avoid false positives.
By the way, my little diatribe about format arguments led to a mechanised search for argument count violations. One found, in eshell, pushed to master as obvious:
diff --git a/lisp/eshell/esh-proc.el b/lisp/eshell/esh-proc.el
index 55251f5bfb..3432582cf4 100644
--- a/lisp/eshell/esh-proc.el
+++ b/lisp/eshell/esh-proc.el
@@ -498,7 +498,7 @@ See the variable `eshell-kill-processes-on-exit'."
(buffer-name))))
(eshell-round-robin-kill
(if (eq eshell-kill-processes-on-exit 'every)
- (format-message "Kill Eshell child process `%s'? "))))
+ "Kill Eshell child process `%s'? ")))
(let ((buf (get-buffer "*Process List*")))
(if (and buf (buffer-live-p buf))
(kill-buffer buf)))
prev parent reply other threads:[~2019-03-20 10:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 13:50 Scan of regexps in Emacs (March 17) Mattias Engdegård
2019-03-19 1:21 ` Paul Eggert
2019-03-19 10:34 ` Mattias Engdegård
2019-03-20 1:53 ` Paul Eggert
2019-03-20 2:20 ` Stefan Monnier
2019-03-20 22:01 ` Paul Eggert
2019-03-20 22:59 ` Drew Adams
2019-03-20 23:10 ` Paul Eggert
2019-03-21 3:38 ` Eli Zaretskii
[not found] ` <<deeccd91-0f43-c329-6087-17435550b328@cs.ucla.edu>
[not found] ` <<83d0mk6go5.fsf@gnu.org>
2019-03-21 4:21 ` Drew Adams
2019-03-21 14:17 ` Eli Zaretskii
2019-03-21 0:57 ` Stefan Monnier
2019-03-21 11:15 ` Mattias Engdegård
2019-04-02 7:33 ` Paul Eggert
2019-04-02 14:15 ` Mattias Engdegård
2019-04-02 14:26 ` Noam Postavsky
2019-04-02 19:13 ` Mattias Engdegård
2019-04-02 16:58 ` Stefan Monnier
2019-04-02 22:08 ` Paul Eggert
2019-04-03 4:52 ` Eli Zaretskii
2019-04-03 17:02 ` Paul Eggert
2019-04-06 9:43 ` Mattias Engdegård
2019-04-07 8:15 ` Michael Albinus
2019-04-07 9:47 ` Paul Eggert
2019-04-07 10:06 ` Mattias Engdegård
2019-04-07 18:45 ` Paul Eggert
2019-03-21 2:07 ` Richard Stallman
2019-03-22 13:26 ` Stephen Leake
2019-03-22 14:03 ` Stefan Monnier
2019-03-22 14:12 ` Mattias Engdegård
2019-03-20 10:04 ` Mattias Engdegård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8FD6CD65-D02A-4DAE-B2D6-8D83F23F3930@acm.org \
--to=mattiase@acm.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).