From: Ihor Radchenko <yantar92@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Arthur Miller <arthur.miller@live.com>,
emacs-devel@gnu.org
Subject: Re: Patch proposal: display symbol source code in help buffers
Date: Mon, 20 Sep 2021 17:04:35 +0800 [thread overview]
Message-ID: <87zgs7y5wc.fsf@localhost> (raw)
In-Reply-To: <CADwFkm=ApvXC7Mq++RE7DQE33yqz-cakO5f-xyaXv62397u7Sg@mail.gmail.com>
Stefan Kangas <stefankangas@gmail.com> writes:
>> Opening help buffer for B is easy - <F1> f <RET> with point at the B's
>> call. However, without source code being shown in the help buffer, if I
>> try to hit s, the narrowing is removed and the point is moved to a
>> function definition. Not convenient.
>
> I'm not arguing against the new feature here, but is the above a bug?
My comment was to resolve your puzzled state about usefulness of the new
feature ;)
> It seems to me that `help-view-source' should respect the users
> narrowing, for example by querying to open a new indirect buffer or
> something in that case.
That would make sense. Yet, even without narrowing, I personally do not
like that the point moves from the defun I am working on to other
function definition.
Also, a subtle difference between showing the source code in help buffer
and jumping to the defun is how much text is shown. In the help buffer,
source code is effectively "narrowed" to defun - no surrounding code is
shown.
Best,
Ihor
next prev parent reply other threads:[~2021-09-20 9:04 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 19:50 Patch proposal: display symbol source code in help buffers Arthur Miller
2021-09-20 5:46 ` Lars Ingebrigtsen
2021-09-20 6:09 ` Stefan Kangas
2021-09-20 6:14 ` Lars Ingebrigtsen
2021-09-20 7:17 ` Ihor Radchenko
2021-09-20 7:43 ` Stefan Kangas
2021-09-20 8:29 ` martin rudalics
2021-09-20 9:04 ` Ihor Radchenko [this message]
2021-09-20 23:45 ` Arthur Miller
2021-09-21 4:16 ` Lars Ingebrigtsen
2021-09-21 6:59 ` Ihor Radchenko
2021-09-21 7:41 ` Stefan Kangas
2021-09-21 8:38 ` Eli Zaretskii
2021-09-21 9:17 ` Ihor Radchenko
2021-09-21 16:49 ` Lars Ingebrigtsen
2021-10-01 7:05 ` Ihor Radchenko
2021-10-01 7:09 ` Lars Ingebrigtsen
2021-10-01 7:21 ` Ihor Radchenko
2021-10-01 7:21 ` Lars Ingebrigtsen
2021-10-01 9:04 ` Ihor Radchenko
2021-10-01 12:20 ` Lars Ingebrigtsen
2021-10-01 7:24 ` Eli Zaretskii
2021-10-01 9:08 ` Ihor Radchenko
2021-10-01 10:24 ` Eli Zaretskii
2021-10-01 14:14 ` Ihor Radchenko
2021-09-21 8:34 ` martin rudalics
2021-09-20 15:01 ` Arthur Miller
2021-09-21 7:41 ` Stefan Kangas
2021-09-20 15:27 ` Arthur Miller
2021-09-20 6:47 ` Eli Zaretskii
2021-09-20 15:27 ` Arthur Miller
2021-09-20 14:55 ` Arthur Miller
2021-09-21 4:18 ` Lars Ingebrigtsen
2021-09-21 10:26 ` Arthur Miller
2021-09-20 15:23 ` Arthur Miller
2021-09-20 5:59 ` Eli Zaretskii
2021-09-20 6:37 ` Gregor Zattler
2021-09-20 7:01 ` Eli Zaretskii
2021-09-20 15:21 ` Arthur Miller
2021-09-20 8:21 ` martin rudalics
2021-09-20 18:13 ` Arthur Miller
2021-09-21 8:34 ` martin rudalics
2021-09-21 10:24 ` Arthur Miller
2021-09-21 16:52 ` martin rudalics
2021-09-21 18:56 ` Arthur Miller
2021-09-21 17:30 ` Juri Linkov
2021-09-21 19:13 ` Arthur Miller
2021-09-22 7:49 ` martin rudalics
2021-09-22 16:04 ` Juri Linkov
2021-09-22 17:52 ` martin rudalics
2021-09-23 8:15 ` martin rudalics
2021-09-23 15:52 ` Juri Linkov
2021-09-26 9:10 ` martin rudalics
2021-09-22 22:38 ` Arthur Miller
2021-09-23 8:22 ` martin rudalics
2021-09-20 12:19 ` Dmitry Gutov
2021-09-20 15:13 ` Arthur Miller
2021-09-20 15:11 ` Arthur Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgs7y5wc.fsf@localhost \
--to=yantar92@gmail.com \
--cc=arthur.miller@live.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).