From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Mon, 20 Sep 2021 17:04:35 +0800 Message-ID: <87zgs7y5wc.fsf@localhost> References: <875yuvlrz3.fsf@gnus.org> <87r1djixiw.fsf@gnus.org> <878rzrzpfz.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35168"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Arthur Miller , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 11:04:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSFDv-000909-4w for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 11:04:27 +0200 Original-Received: from localhost ([::1]:45644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSFDt-0006bo-JX for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 05:04:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSFCs-0005nz-OP for emacs-devel@gnu.org; Mon, 20 Sep 2021 05:03:23 -0400 Original-Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:40849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSFCr-0006xL-C7 for emacs-devel@gnu.org; Mon, 20 Sep 2021 05:03:22 -0400 Original-Received: by mail-pf1-x433.google.com with SMTP id y8so15575070pfa.7 for ; Mon, 20 Sep 2021 02:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=EeCzVLU2nd0Gv6qjK64llFoUKA7GxeLB8D5ZKkU/AVI=; b=JZS3zddbsLkXfa7r7Zz7H1RWKHxYj2XwlwVa0T+Uqxzrf5PlYGZU7EMpyuM1WlFiqO fpRq1LkPLBePtG4TP6IIfJVnJlLHF6dFtCEWob5GcJ/MV7vZk2rsu9/4dsiGwyN9ERBx v9lgrmJHk/Hx++F++JhoI/R5d8hjwdYmwglyLnuzj77uxVchvHJTMdpJ4ZuZKyPrBbn6 NACz+PKB1hOffskTJA0g9dEP3mosNeh3cmLprpFMiHV8+3yVwoAQgjg+sqcHy4KD81m0 co0GStMYdSGAdy2bftZmcyCWeGPg+G9IfiopuQiAp0FY8KHZVfGL1eTcyBXG3MhO+jwy zwpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=EeCzVLU2nd0Gv6qjK64llFoUKA7GxeLB8D5ZKkU/AVI=; b=J/PswRfg9Na9eAOasAh3O/daIO3SfELkGb5wW7CcxEeE6fhawWWY7TSYhu/hfKYg/+ GGoNetuI9Ln/Gc4gq/sPYEAgY30zSEr15udlfWDlDUuDnG+2D/OtqFLODJbKcn4eSxJO IT6anvdEHRlMntNlS9uCZbHnQtUkJvWEFX2v4tnCGEUJAVesFZ6DKHhejzQuL37w+/1c RNCtSct8YFOpVHridD0xnH5g3gttgH65UL+XJ+I6O57oy9oYiLXypS0vBeKMFT3tpZuJ mb5s5Pd5ygFt7PUPR34NSeMBX2tRno9aP5PoJvqHzuPHxFfXYqihoFCLJ+fXe81gQfmS ag0Q== X-Gm-Message-State: AOAM531DrxGKg7+Sym0KbBON6Xbq/aELXfPb/QI+Vl5lXc2VI9zhZK51 +VHF9mduWKsafPWCqFqkkuo= X-Google-Smtp-Source: ABdhPJzT2NLbDzs57OawzDSdtQIexs0sxQ2luRP1nnEzBrNru+hHpmrZrYLTZ0XyQ2eYeQ07o5uzTQ== X-Received: by 2002:aa7:9d02:0:b0:43d:ea96:5882 with SMTP id k2-20020aa79d02000000b0043dea965882mr23881443pfp.23.1632128598914; Mon, 20 Sep 2021 02:03:18 -0700 (PDT) Original-Received: from localhost ([206.190.157.238]) by smtp.gmail.com with ESMTPSA id j25sm13025824pff.34.2021.09.20.02.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 02:03:18 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=yantar92@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275119 Archived-At: Stefan Kangas writes: >> Opening help buffer for B is easy - f with point at the B's >> call. However, without source code being shown in the help buffer, if I >> try to hit s, the narrowing is removed and the point is moved to a >> function definition. Not convenient. > > I'm not arguing against the new feature here, but is the above a bug? My comment was to resolve your puzzled state about usefulness of the new feature ;) > It seems to me that `help-view-source' should respect the users > narrowing, for example by querying to open a new indirect buffer or > something in that case. That would make sense. Yet, even without narrowing, I personally do not like that the point moves from the defun I am working on to other function definition. Also, a subtle difference between showing the source code in help buffer and jumping to the defun is how much text is shown. In the help buffer, source code is effectively "narrowed" to defun - no surrounding code is shown. Best, Ihor