From: Michael Albinus <michael.albinus@gmx.de>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches
Date: Sat, 08 Oct 2022 14:43:41 +0200 [thread overview]
Message-ID: <87zge6cwoy.fsf@gmx.de> (raw)
In-Reply-To: <87v8oufpzm.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 08 Oct 2022 12:40:13 +0000")
Philip Kaludercic <philipk@posteo.net> writes:
Hi Philip,
>> Both functions haven't a docstring. Now that we mention them in NEWS,
>> they should get it, shouldn't they?
>
> How do you like the following:
I don't know too much about vc.el implementation, so it doesn't matter
how I do like :-)
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 14b149310c..2867539aa3 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -1926,6 +1926,13 @@ vc-revision-history
> "History for `vc-read-revision'.")
>
> (defun vc-read-revision (prompt &optional files backend default initial-input multiple)
> + "Query the user for a revision using PROMPT.
> +All subsequent arguments are optional. FILES may specify a file
> +set to restrict the revisions to. BACKEND is a VC backend as
> +listed in `vc-handled-backends'. DEFAULT and INITIAL-INPUT are
> +handled as defined by `completing-read'. If MULTIPLE is non-nil,
> +the user may be prompted for multiple revisions. If possible
> +this means that `completing-read-multiple' will be used."
> (cond
> ((null files)
> (let ((vc-fileset (vc-deduce-fileset t))) ;FIXME: why t? --Stef
> @@ -1947,6 +1954,10 @@ vc-read-revision
> answer)))))
>
> (defun vc-read-multiple-revisions (prompt &optional files backend default initial-input)
> + "Query the user for multiple revisions.
> +This is equivalent to invoking `vc-read-revision' with t for
> +MULTIPLE. The arguments PROMPT, FILES, BACKEND, DEFAULT and
> +INITIAL-INPUT are passed on to `vc-read-revision' directly."
> (vc-read-revision prompt files backend default initial-input t))
>
> (defun vc-diff-build-argument-list-internal (&optional fileset)
With my limited scope, it looks OK.
Best regards, Michael.
next prev parent reply other threads:[~2022-10-08 12:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166522273249.875.4607071661972312638@vcs2.savannah.gnu.org>
[not found] ` <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org>
2022-10-08 12:03 ` master 59df0a7bd9: Add a VC command to prepare patches Michael Albinus
2022-10-08 12:40 ` Philip Kaludercic
2022-10-08 12:43 ` Michael Albinus [this message]
2022-10-08 17:19 ` Sean Whitton
2022-10-08 17:29 ` Philip Kaludercic
2022-10-08 17:51 ` Sean Whitton
2022-10-09 12:30 ` Philip Kaludercic
2022-10-12 22:53 ` Sean Whitton
2022-11-15 19:18 ` Philip Kaludercic
2022-11-16 0:06 ` Sean Whitton
2022-11-16 8:18 ` Philip Kaludercic
2022-10-08 17:32 ` Philip Kaludercic
2022-10-10 10:52 ` Robert Pluim
2022-10-10 11:22 ` Philip Kaludercic
2022-10-10 14:18 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zge6cwoy.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).