From: Philip Kaludercic <philipk@posteo.net>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: emacs-devel@gnu.org
Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches
Date: Tue, 15 Nov 2022 19:18:35 +0000 [thread overview]
Message-ID: <87edu458ms.fsf@posteo.net> (raw)
In-Reply-To: <87y1tqp6l6.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 08 Oct 2022 19:29:09 +0200")
Philip Kaludercic <philipk@posteo.net> writes:
> Sean Whitton <spwhitton@spwhitton.name> writes:
>
>> Hello,
>>
>> On Sat 08 Oct 2022 at 05:52AM -04, Philip Kaludercic wrote:
>>
>>> +@vindex vc-prepare-patches-separately
>>> +Depending on the value of the user option
>>> +@code{vc-prepare-patches-separately}, @code{vc-prepare-patch} will
>>> +generate one or more messages. The default value @code{t} means
>>> +prepare and display a message for each revision, one after another. A
>>> +value of @code{nil} means to generate a single message with all
>>> +patches attached in the body.
>>> +
>>> +@vindex vc-default-patch-addressee
>>> +If you expect to contribute patches on a regular basis, you can set
>>> +the user option @code{vc-default-patch-addressee} to the address(es)
>>> +you wish to use. This will be used as the default value when invoking
>>> +@code{vc-prepare-patch}. Project maintainers may consider setting
>>> +this as a directory local variable (@pxref{Directory Variables}).
>>> +
>>
>> Please excuse me if I missed discussion in a bug, but wouldn't it make
>> sense to set *both* of these in .dir-locals.el for emacs.git?
>
> Yes, but I would wait a bit to avoid the same issues as we had when
> `diff-add-log-use-relative-names' was set. Anyone who had pulled the
> new commits with the change but hadn't rebuilt Emacs to know that these
> are safe values was prompted the "are you sure these variables are safe"
> queries. If we wait for a week or two then I would guess that most
> people following development will have pulled and rebuilt at least once
> by then.
I guess enough time has gone by and the variable could be added to
.dir-locals.el?
next prev parent reply other threads:[~2022-11-15 19:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166522273249.875.4607071661972312638@vcs2.savannah.gnu.org>
[not found] ` <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org>
2022-10-08 12:03 ` master 59df0a7bd9: Add a VC command to prepare patches Michael Albinus
2022-10-08 12:40 ` Philip Kaludercic
2022-10-08 12:43 ` Michael Albinus
2022-10-08 17:19 ` Sean Whitton
2022-10-08 17:29 ` Philip Kaludercic
2022-10-08 17:51 ` Sean Whitton
2022-10-09 12:30 ` Philip Kaludercic
2022-10-12 22:53 ` Sean Whitton
2022-11-15 19:18 ` Philip Kaludercic [this message]
2022-11-16 0:06 ` Sean Whitton
2022-11-16 8:18 ` Philip Kaludercic
2022-10-08 17:32 ` Philip Kaludercic
2022-10-10 10:52 ` Robert Pluim
2022-10-10 11:22 ` Philip Kaludercic
2022-10-10 14:18 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edu458ms.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).