From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches Date: Sat, 08 Oct 2022 14:43:41 +0200 Message-ID: <87zge6cwoy.fsf@gmx.de> References: <166522273249.875.4607071661972312638@vcs2.savannah.gnu.org> <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org> <874jweed48.fsf@gmx.de> <87v8oufpzm.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33612"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 08 14:45:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oh9D5-0008bb-UA for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 14:45:43 +0200 Original-Received: from localhost ([::1]:38078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oh9D4-0002yY-IW for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 08:45:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh9BD-00011A-B5 for emacs-devel@gnu.org; Sat, 08 Oct 2022 08:43:47 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:43053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh9BB-0007K0-2y for emacs-devel@gnu.org; Sat, 08 Oct 2022 08:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665233022; bh=nGvzDUzKrYZLNJL8Cy6pfVdQKKyTmGdMSdLQc8LCi/4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=H1opA3XPLHpwwG/a2VtQ0HNGjw/HMnh1QzLa0Y9ZVKyu4V29u+2FH1HWTU1kN7wDK 5Up5D6CQ/6BNonRv3ztETFIs36qsmh0YsnpkM2df0hBdYnxTRodMdM3R7O9m8o+Nzj FiSpaHa3cW0TU7Cc+vawbb2WPrv8WsaJrImvCh0g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.148.171]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N1Obb-1pA4BR15n1-012pbF; Sat, 08 Oct 2022 14:43:42 +0200 In-Reply-To: <87v8oufpzm.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 08 Oct 2022 12:40:13 +0000") X-Provags-ID: V03:K1:C+psYc1oMu+TBx6XfnPEALhWUgabBG6Wk7D75CMNHQiYOP/2RA7 gw5qrCZ4o7Wyyb+T5PNDxlyDDdML0hKkpNC75nouQUUOBWTYuDkg5g3YnuNgGtoY5TcvUlL 5C+GpaRqFnPxw4qdbOC5WX5EPQcpaK3OzT7hHf+g7DYKF+L3FoEg2MrJNr3EuxU1JdeR/IS M0a8DaF/qBlA5+hmq7Kqw== X-UI-Out-Filterresults: notjunk:1;V03:K0:mR720ZGlhuo=:JaObKGoiz0vJ39CZQjwFRS kBC+Ju+wix2Te9eaMRV4Z/iwNWLDLH1dq6AgZz9CHIwLiNBcZSOoMRDLBAAqF7Q4lZ8p4dwNF v1LSv/zdwoSPCqruWYKiCrQtSdoK/aR5I1Ibrq1wv+rQavpT57DI6/VkJyPXT4vefDH/4vvw1 rj7BWv2xbr2N92ahFsV3iT8LodOIfSTFoNKvSirJxVAF5LFr98X3Oq/VDExtsAbFNd4Dwm0SZ o1sk43pxtHlYXm2Nhu+Xm6vTOk9K+D3vwYke2XBCIrgLvs3TmN4iESmnRq0Fplk8wJh7Rr5pV ufY6Fz/lcWVtqMS9Ey5NTQ7NUtE7ZNgCGYQns475uyFgbYLaH2HFJltG8A0VnMzOy5Nclbn+V SuT5FUyqA1KjJqBFhlCt7d5MjZQODVjlt4/2a6rvndE/KRHTxUAudBsGGrs4KJphimWr4UuLs rHbpNxxDxKcoffsyFEI6bT0ZZW4ajmtytfSXxWnRU9kF+C6jPvZjIN2MFLH4Zf/vSz5t0ouLN kfCTVQxn+4VJdBJi+XIKDV2mV8tutwiSSGybuwaQnCprFRHeIo0laFYJPbQaxFnb6+V2tLflr YaklSHu3iTcLnk/LZVnXETwbqn2ibQhWGKFGY0udiM6Zyd3JBIhlMomT3HRkBDBZ5X0Wjwgst qySS5TyCY0VxptDtUAaNbywtPsJTBXPgnTVH0lZxLdGcfu+L2ekot1mtoZ69m0FR1cr5qI7CG 8kkVuL/hqvm3tJtOnxy0WxGaV3APGnKjJA21eCU8V/yUDZjBWRfPo9O7gdFG4T6sjXFuXMhx Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297201 Archived-At: Philip Kaludercic writes: Hi Philip, >> Both functions haven't a docstring. Now that we mention them in NEWS, >> they should get it, shouldn't they? > > How do you like the following: I don't know too much about vc.el implementation, so it doesn't matter how I do like :-) > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index 14b149310c..2867539aa3 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -1926,6 +1926,13 @@ vc-revision-history > "History for `vc-read-revision'.") > > (defun vc-read-revision (prompt &optional files backend default initial= -input multiple) > + "Query the user for a revision using PROMPT. > +All subsequent arguments are optional. FILES may specify a file > +set to restrict the revisions to. BACKEND is a VC backend as > +listed in `vc-handled-backends'. DEFAULT and INITIAL-INPUT are > +handled as defined by `completing-read'. If MULTIPLE is non-nil, > +the user may be prompted for multiple revisions. If possible > +this means that `completing-read-multiple' will be used." > (cond > ((null files) > (let ((vc-fileset (vc-deduce-fileset t))) ;FIXME: why t? --Stef > @@ -1947,6 +1954,10 @@ vc-read-revision > answer))))) > > (defun vc-read-multiple-revisions (prompt &optional files backend defau= lt initial-input) > + "Query the user for multiple revisions. > +This is equivalent to invoking `vc-read-revision' with t for > +MULTIPLE. The arguments PROMPT, FILES, BACKEND, DEFAULT and > +INITIAL-INPUT are passed on to `vc-read-revision' directly." > (vc-read-revision prompt files backend default initial-input t)) > > (defun vc-diff-build-argument-list-internal (&optional fileset) With my limited scope, it looks OK. Best regards, Michael.