From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Simple lisp-tests.el and commit privs Date: Thu, 15 Aug 2013 00:23:12 +0300 Message-ID: <87y584c6gv.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376515415 26492 80.91.229.3 (14 Aug 2013 21:23:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Aug 2013 21:23:35 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Barry OReilly Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 14 23:23:36 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V9iXX-0002Lm-Ol for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2013 23:23:35 +0200 Original-Received: from localhost ([::1]:50153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9iXX-0003Uh-9i for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2013 17:23:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9iXO-0003Ou-Oi for emacs-devel@gnu.org; Wed, 14 Aug 2013 17:23:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9iXJ-0003aO-DJ for emacs-devel@gnu.org; Wed, 14 Aug 2013 17:23:26 -0400 Original-Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:60958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9iXJ-0003a9-7F for emacs-devel@gnu.org; Wed, 14 Aug 2013 17:23:21 -0400 Original-Received: by mail-ea0-f170.google.com with SMTP id h14so5070614eak.15 for ; Wed, 14 Aug 2013 14:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=RwjCbHZyhwjs6FL0+I1YyGObuw2il0AxOP04m2bS5qo=; b=YV7nJjeld+9wLH/tLnuXgD4r6qqAwPcl/Ql/SAabs2MMHPmhPPD2p6BKjb0wGnw4Et SkbA29i9+JhrYNyDbMm6mYppcwRnGFC7t8wksNlMuSKjuhz6SpKixRHWF/Ag/FFROAgF 8vVlTSiOsFZVb/nKL6j3TwFuDaaheFcrVNdHTNAJaQjEocYse22zVyGiclQtiDhv1Pcy iH6o6kizNstsKVwag+vUKGx+QR00WiChXTZHVTns1U+5qWBFYHp7iuhQZAtKVTSguQfY L8aNd8uzjp0noxSw1IzksYIgrPUOb1Z+7R7mXK7U8tEHimmEjkenawfFcR5EOHtBA12h KNRQ== X-Received: by 10.14.88.65 with SMTP id z41mr17015639eee.38.1376515400508; Wed, 14 Aug 2013 14:23:20 -0700 (PDT) Original-Received: from axl (62-107-247.netrun.cytanet.com.cy. [62.228.107.247]) by mx.google.com with ESMTPSA id z12sm4239389eev.6.2013.08.14.14.23.18 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 14 Aug 2013 14:23:19 -0700 (PDT) In-Reply-To: (Barry OReilly's message of "Wed, 14 Aug 2013 13:49:47 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162741 Archived-At: Barry OReilly writes: > Stefan: >> Currently, the way I like to handle indentation tests is by adding >> files in test/indent/ where the file simply contains a pre-indented >> content, and the Makefile lets you "reindent, then run diff to see >> if something changed". > > I couldn't tell, since test/automated has ERT indentation tests for > Python, Ruby, and Fortran. Those are written by people other than Stefan, e.g. me. There was a relevant discussion not too long ago, in emacs-diffs (sorry, my fault): http://lists.gnu.org/archive/html/emacs-diffs/2013-05/msg00275.html It concluded with a corollary to use the files in test/indent for simple indentation tests, and ERT for more complex stuff. Yet, as reluctant as I was to disagree, I couldn't eventually bring myself to take the [separate, uniquely named] indentation tests from ruby-mode-test.el and lump them together, so to speak, into ruby.rb. So, as far as I'm concerned, a better solution would be to extend ERT runner with a command that would pop a buffer in which a test had failed, so that the programmer can "try out sexp movement and indentation functions "in the usual way", together with Edebug if needed", as per Stefan's explanation.