From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master 97400c4c24: Make printing mostly non-recursive (bug#55481)
Date: Wed, 18 May 2022 17:55:33 +0800 [thread overview]
Message-ID: <87y1yzkvvu.fsf@yahoo.com> (raw)
In-Reply-To: <20220518090526.4AA10C009A8@vcs2.savannah.gnu.org> ("Mattias Engdegård"'s message of "Wed, 18 May 2022 05:05:26 -0400 (EDT)")
Mattias Engdegård <mattiase@acm.org> writes:
> +struct print_pp_entry {
> + ptrdiff_t n; /* number of values, or 0 if a single value */
> + union {
> + Lisp_Object value; /* when n = 0 */
> + Lisp_Object *values; /* when n > 0 */
> + } u;
> +};
> +
> +struct print_pp_stack {
> + struct print_pp_entry *stack; /* base of stack */
> + ptrdiff_t size; /* allocated size in entries */
> + ptrdiff_t sp; /* current number of entries */
> +};
Thanks; however, I think our coding style is to put the opening brace of
structs, enums and unions on column 1, so this should be:
> +struct print_pp_entry
> +{
> + ptrdiff_t n; /* number of values, or 0 if a single value */
> + union
> + {
> + Lisp_Object value; /* when n = 0 */
> + Lisp_Object *values; /* when n > 0 */
> + } u;
> +};
> +
> +struct print_pp_stack
> +{
> + struct print_pp_entry *stack; /* base of stack */
> + ptrdiff_t size; /* allocated size in entries */
> + ptrdiff_t sp; /* current number of entries */
> +};
Instead.
next parent reply other threads:[~2022-05-18 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165286472597.14890.11407291537527786185@vcs2.savannah.gnu.org>
[not found] ` <20220518090526.4AA10C009A8@vcs2.savannah.gnu.org>
2022-05-18 9:55 ` Po Lu [this message]
2022-05-18 14:40 ` master 97400c4c24: Make printing mostly non-recursive (bug#55481) Mattias Engdegård
2022-05-19 1:09 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1yzkvvu.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).