unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 97400c4c24: Make printing mostly non-recursive (bug#55481)
Date: Thu, 19 May 2022 09:09:37 +0800	[thread overview]
Message-ID: <87h75ml44u.fsf@yahoo.com> (raw)
In-Reply-To: <E90C45CA-8010-4FD8-9B6F-A96374619331@acm.org> ("Mattias Engdegård"'s message of "Wed, 18 May 2022 16:40:39 +0200")

Mattias Engdegård <mattiase@acm.org> writes:

> I wasn't sure and there appeared to be considerable variation in the
> existing source (almost 300 cases of bracket on the same line, against
> 500-something with the bracket on a separate line), so I went with the
> former since it is more economic in vertical space without worsening
> readability.

Unfortunately, that contradicts our own coding standards.

> Naturally I'll change if that is important, but then there's a lot of
> code to change, and apparently there is no clear consensus among
> previous authors.

All of that code is formatted incorrectly, but reformatting existing
code breaks various things, such as vc-annotate.  What I think is wrong
is to introduce new instances of the incorrect formatting (such as
here), since our coding standards say:

  For struct and enum types, likewise put the braces in column one,
  unless the whole contents fits on one line:

    struct foo
    {
      int a, b;
    }

  or

    struct foo { int a, b; }



      reply	other threads:[~2022-05-19  1:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165286472597.14890.11407291537527786185@vcs2.savannah.gnu.org>
     [not found] ` <20220518090526.4AA10C009A8@vcs2.savannah.gnu.org>
2022-05-18  9:55   ` master 97400c4c24: Make printing mostly non-recursive (bug#55481) Po Lu
2022-05-18 14:40     ` Mattias Engdegård
2022-05-19  1:09       ` Po Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h75ml44u.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).