From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 97400c4c24: Make printing mostly non-recursive (bug#55481) Date: Wed, 18 May 2022 17:55:33 +0800 Message-ID: <87y1yzkvvu.fsf@yahoo.com> References: <165286472597.14890.11407291537527786185@vcs2.savannah.gnu.org> <20220518090526.4AA10C009A8@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31543"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 18 11:57:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrGQx-0007sH-6M for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 11:57:35 +0200 Original-Received: from localhost ([::1]:53648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrGQv-0001u6-Pa for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 05:57:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrGPE-0000aB-5n for emacs-devel@gnu.org; Wed, 18 May 2022 05:55:48 -0400 Original-Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:43328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrGPC-0004BT-7R for emacs-devel@gnu.org; Wed, 18 May 2022 05:55:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652867743; bh=gYci/Z1evRAv1ADC6/GMreHQm1SdtWnDXPU5heR0EZk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=nO3hI/j7SQLLlvrJpAsaW3AQe9ES2GwcP1424bEwa3dHiQvz9YYZBNjgccf1yKZpCKcErS7FW9uT7Mg39QjcJ6bzKTW8KFTpKTgrvxauIs6ZluAme74O2Q6rmRs475ZxEdaoa+DMj2E8OJ1c+oMllhQ4kwkt0/CVKCUIDJoKRtEvMRX42CaqAUNlaCn+yjuq/HNqKYXs1jDUF1dDV2InP7vSeCLZGAV1vYuAH04Lu4KHaGvdApUs7eTlS7ENpFrVqbP8RoDkNR0al8Iw+lBEfVmJYBGsyRvtLO9XN3pUVDFIZ59jRxyvgC/lXFl5pYVq8T2JpCD4uuicdClAB+uZMw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652867743; bh=Bd/YybalD7UQ+VCf82tIYyzxDnKX78N0QfAx3ESjnXM=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=OhbSxaKmcqTzf568uZlhDJRT8vpWXCHNdV6arMxS8pj/u9d4h0R4RpuT29ktiOkZtMOVMPql1t+ZmpdiWC1aKHsHE9gGdg0roqSabkbcBgmOzet3E198It1oqh5Ca8FP7gM46HEtOJrgrcg6Wus4m8jWYqP60D1J61S2MYsZR6AWz3s1TTcLWpOftpifgoyGi24JyM84n8W1D+p+9CHx9fvBwe6Cd0hqRpSoVxo6UXouTqYHdlyjACKnSf7fE8nNXuw6lxKbQT3eoPAm0LUZVidPfJL4J1nH2inGVwwd3hmUS9e2wo84/iGhSEUfE8Chz/NOGNxhHI17PWnayR7OaA== X-YMail-OSG: k7twCA8VM1ki8Ew3eCGR_Qh6wgDiLqURm4Fk.w4UDZaNTSF_n9Inw_bwaYGZH4P pNmxBBg2fPuqeCdMmhkyQv4gnPP6PX50hYYJosXKK3Zkednu.n71b8Gmn9wlfOUfUOzi7XAWrgbg mY4AK8y25GVeHqHJPv_Ok3TXGE0A5cPC9XGa3vDV7UM_i5oJ6vq9aeSKi6XIcCTRhn5tv7g9RN1Q FFvAnpSq345Vkdu_Jve8itNpub7yXng.SqTgDvTSqxvuqJfgGBwGH4JUp6k0qA6TkgUHwKlLwPfz D0HNnKd4B4GJmN0ONu2SrAxOeu2zn04k15.HOIYr5LVrFCzHxCfvj8WwVgDlil.N5eaOf8jx.ylz FT5BHUZpJSK.wauxvZQL5YoBTy8swK4RdXckh6gzWa2i4PePJzf.Ki5O3mEQkhyvt6_yDwU5qzKt JpRjT7rgwpG1UxL81dav7raAfiZbKpHFzf2AVAirQaEa8HsqVYcACG2IwLmCtIoW.PM0Pe1c7UPX ZvtsHCII7R2zpxEMu6VUY1hCotRV9YVK.iHCvQ_rhsxgqSbveTczldFJiQGYXZEYV9wl5uewDx3C huI6T0ZaTODWJtz.UJC6VevQfXIAueSgYAcQf_h7gQ8aVlhePKqXBuuyzDWlWX24K5PNk_6bbvt1 mTkJXdW0hnCLWvMb3kmYzOjdZ1TDQrtnX2g3dKJNBFpKHgzzimXdI4DrcshGSWtzYSkAmkKy1Npm Zmd2ee.nz5F8_M3gLVjLpQbq9DyWzeiOxsPsREznOU69DpyJ1HNbuF35a9YsDRNhazN2Fmbr7K.B 4HGBX6EHTZWcun3ex56z_lFI2PJujFVoo3hIPiE7jI X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Wed, 18 May 2022 09:55:43 +0000 Original-Received: by hermes--canary-production-sg3-6f849d4c49-4klwm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1de9e39bfe64a1b07029900741794593; Wed, 18 May 2022 09:55:39 +0000 (UTC) In-Reply-To: <20220518090526.4AA10C009A8@vcs2.savannah.gnu.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 18 May 2022 05:05:26 -0400 (EDT)") X-Mailer: WebService/1.1.20188 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.31; envelope-from=luangruo@yahoo.com; helo=sonic308-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289912 Archived-At: Mattias Engdeg=C3=A5rd writes: > +struct print_pp_entry { > + ptrdiff_t n; /* number of values, or 0 if a single value */ > + union { > + Lisp_Object value; /* when n =3D 0 */ > + Lisp_Object *values; /* when n > 0 */ > + } u; > +}; > + > +struct print_pp_stack { > + struct print_pp_entry *stack; /* base of stack */ > + ptrdiff_t size; /* allocated size in entries */ > + ptrdiff_t sp; /* current number of entries */ > +}; Thanks; however, I think our coding style is to put the opening brace of structs, enums and unions on column 1, so this should be: > +struct print_pp_entry > +{ > + ptrdiff_t n; /* number of values, or 0 if a single value */ > + union > + { > + Lisp_Object value; /* when n =3D 0 */ > + Lisp_Object *values; /* when n > 0 */ > + } u; > +}; > + > +struct print_pp_stack > +{ > + struct print_pp_entry *stack; /* base of stack */ > + ptrdiff_t size; /* allocated size in entries */ > + ptrdiff_t sp; /* current number of entries */ > +}; Instead.