unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: font-lock-comment-delimiter-face
Date: Fri, 13 May 2005 00:11:38 -0400	[thread overview]
Message-ID: <87wtq3ydmf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1DVu1p-0003VB-Nk@fencepost.gnu.org> (Richard Stallman's message of "Wed, 11 May 2005 12:25:45 -0400")

>     Seems odd to introduce a new face whose name refers to "comment" even
>     though the only two known uses for it are not for comments but for
>     email citations.

> Those were the only uses yet implemented for it,
> but now I've changed font-lock-fontify-syntactically-region
> to use it for comment delimiters.  I think this will work
> for all modes.  It works for C mode and Lisp mode.

Taking a second look at the idea I can't help feeling like it's the wrong
solution.  Basically, nobody has ever requested for comment-delimiters to be
hilighted differently than the comment body, so we're adding a feature that
nobody asked for (and this, one-year into a feature freeze).

Problem is that this feature doesn't work quite right: the border cases are
non-trivial and nobody has the expertise/time/willingness to fix it.

But the oddest part of all is that this was introduced because of something
completely unrelated: the ability to mark mail quoting-prefix without
marking the quoted text.  And this, of course, has nothing to do with
comments, other than an accidental reuse of font-lock-comment-face.

Please, let's rename this new face to something sensible like
mail-citation-prefix-face (or the same without the "-face" suffix) and stop
the madness about comment delimiters.


        Stefan

  parent reply	other threads:[~2005-05-13  4:11 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-23 22:51 font-lock-comment-delimiter-face Richard Stallman
2005-04-24  9:59 ` font-lock-comment-delimiter-face Eli Zaretskii
2005-04-24 18:43 ` font-lock-comment-delimiter-face Kim F. Storm
2005-04-24 20:27   ` Feature freeze (was Re: font-lock-comment-delimiter-face) Glenn Morris
2005-04-24 21:46     ` Thien-Thi Nguyen
2005-04-24 21:56       ` Eli Zaretskii
2005-04-26 10:05       ` Richard Stallman
2005-04-25 16:05   ` font-lock-comment-delimiter-face Richard Stallman
2005-04-25 22:20     ` font-lock-comment-delimiter-face Luc Teirlinck
2005-04-26 20:58 ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-11 16:25   ` font-lock-comment-delimiter-face Richard Stallman
2005-05-11 19:51     ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-13  1:34       ` font-lock-comment-delimiter-face Richard Stallman
2005-05-13  3:45         ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-14  0:26           ` font-lock-comment-delimiter-face Richard Stallman
2005-05-13  4:11     ` Stefan Monnier [this message]
2005-05-13  8:21       ` font-lock-comment-delimiter-face Kim F. Storm
2005-05-13 13:15         ` font-lock-comment-delimiter-face Eli Zaretskii
2005-05-13 13:36           ` font-lock-comment-delimiter-face David Kastrup
2005-05-13 19:27             ` font-lock-comment-delimiter-face Edward O'Connor
2005-05-13 20:50               ` font-lock-comment-delimiter-face Daniel Brockman
2005-05-14  0:25       ` font-lock-comment-delimiter-face Richard Stallman
2005-05-14  1:25         ` font-lock-comment-delimiter-face Nick Roberts
2005-05-14 15:12           ` font-lock-comment-delimiter-face Richard Stallman
2005-05-14 22:43             ` font-lock-comment-delimiter-face Nick Roberts
2005-05-14 23:55               ` font-lock-comment-delimiter-face Paul Pogonyshev
2005-05-15  9:48               ` font-lock-comment-delimiter-face David Kastrup
2005-05-15 22:39                 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-15 22:50                   ` font-lock-comment-delimiter-face David Kastrup
2005-05-16 19:28                     ` font-lock-comment-delimiter-face Richard Stallman
2005-05-17 20:09                       ` font-lock-comment-delimiter-face Edward O'Connor
2005-05-18 22:44                         ` font-lock-comment-delimiter-face Richard Stallman
2005-05-19  0:01                           ` font-lock-comment-delimiter-face Lute Kamstra
2005-05-19 13:02                           ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-19 14:44                             ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-19 15:01                               ` font-lock-comment-delimiter-face Kim F. Storm
2005-05-20 21:57                               ` font-lock-comment-delimiter-face Richard Stallman
2005-05-19 15:01                             ` font-lock-comment-delimiter-face Kim F. Storm
2005-05-19 15:46                               ` font-lock-comment-delimiter-face David Kastrup
2005-05-19 16:52                           ` font-lock-comment-delimiter-face Dan Nicolaescu
2005-05-20 21:56                             ` font-lock-comment-delimiter-face Richard Stallman
2005-05-21 17:51                               ` font-lock-comment-delimiter-face Dan Nicolaescu
2005-05-15 15:58               ` font-lock-comment-delimiter-face Richard Stallman
2005-05-18 18:02                 ` font-lock-comment-delimiter-face Romain Francoise
2005-05-14 16:11     ` font-lock-comment-delimiter-face Ralf Angeli
2005-05-15 15:59       ` font-lock-comment-delimiter-face Richard Stallman
2005-05-15 17:34         ` font-lock-comment-delimiter-face Ralf Angeli
2005-05-16  3:55           ` font-lock-comment-delimiter-face Richard Stallman
2005-05-16  8:16             ` font-lock-comment-delimiter-face Ralf Angeli
2005-05-16 21:20               ` font-lock-comment-delimiter-face Richard Stallman
2005-05-17  7:30                 ` font-lock-comment-delimiter-face Ralf Angeli
2005-05-18 23:22                   ` font-lock-comment-delimiter-face Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2005-05-13  0:11 font-lock-comment-delimiter-face Lute Kamstra
2005-05-13  3:37 ` font-lock-comment-delimiter-face Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wtq3ydmf.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).