From: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: font-lock-comment-delimiter-face
Date: Sat, 21 May 2005 10:51:42 -0700 [thread overview]
Message-ID: <200505211751.j4LHpiKE003108@scanner2.ics.uci.edu> (raw)
In-Reply-To: <E1DZFU8-0003rx-La@fencepost.gnu.org> (Richard Stallman's message of "Fri, 20 May 2005 17:56:48 -0400")
Richard Stallman <rms@gnu.org> writes:
> If the red colored comments are hard to read on a console, can't we
> just change the face foreground for font-lock-comment-face for that
> situation (i.e. min-colors == 8 and background-mode == 'dark)?
> It seems to me that would be a lot easier than adding
> font-lock-comment-delimiter-face route?
>
> I am not entirely sure what you're proposing.
> Could you be more specific? I could try it out.
Your original complaint was that font-lock-comment-face that has
face-foreground "red" is hard to read on a console. I am proposing to
just change that "red" color to some other color that is readable on a
console.
> So just do M-x list-colors-display RET pick a color for comments and
> I'll do the needed change.
>
> Please don't install such a change, but I'd appreciate it if you sent
> me a patch to try.
I had no intention of installing a change without reaching some
consensus. That would not be wise given the amount of discussions
going on.
Please try this patch:
*** font-lock.el 20 May 2005 15:40:40 -0700 1.257
--- font-lock.el 21 May 2005 10:36:03 -0700
***************
*** 1678,1686 ****
(((class color) (min-colors 16) (background dark))
(:foreground "red1"))
(((class color) (min-colors 8) (background light))
! )
(((class color) (min-colors 8) (background dark))
! )
(t (:weight bold :slant italic)))
"Font Lock mode face used to highlight comments."
:group 'font-lock-highlighting-faces)
--- 1678,1691 ----
(((class color) (min-colors 16) (background dark))
(:foreground "red1"))
(((class color) (min-colors 8) (background light))
! ;; IMHO this should not have been changed, red is quite readable
! ;; on a light background (e.g. xterm -bg white)
! (:foreground "red"))
(((class color) (min-colors 8) (background dark))
! ;; Change the color here if you want to see how other colors
! ;; look like for comments.
! ;; You can choose one of: black red green yellow blue magenta cyan white
! (:foreground "yellow"))
(t (:weight bold :slant italic)))
"Font Lock mode face used to highlight comments."
:group 'font-lock-highlighting-faces)
***************
*** 1689,1698 ****
'((default :inherit font-lock-comment-face)
(((class grayscale)))
(((class color) (min-colors 16)))
! (((class color) (min-colors 8) (background light))
! :foreground "red")
! (((class color) (min-colors 8) (background dark))
! :foreground "red1"))
"Font Lock mode face used to highlight comment delimiters."
:group 'font-lock-highlighting-faces)
--- 1694,1705 ----
'((default :inherit font-lock-comment-face)
(((class grayscale)))
(((class color) (min-colors 16)))
! ;; Commented out to disable the effects of font-lock-comment-delimiter-face
! ;; (((class color) (min-colors 8) (background light))
! ;; :foreground "red")
! ;; (((class color) (min-colors 8) (background dark))
! ;; :foreground "red1"))
! )
"Font Lock mode face used to highlight comment delimiters."
:group 'font-lock-highlighting-faces)
next prev parent reply other threads:[~2005-05-21 17:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-23 22:51 font-lock-comment-delimiter-face Richard Stallman
2005-04-24 9:59 ` font-lock-comment-delimiter-face Eli Zaretskii
2005-04-24 18:43 ` font-lock-comment-delimiter-face Kim F. Storm
2005-04-24 20:27 ` Feature freeze (was Re: font-lock-comment-delimiter-face) Glenn Morris
2005-04-24 21:46 ` Thien-Thi Nguyen
2005-04-24 21:56 ` Eli Zaretskii
2005-04-26 10:05 ` Richard Stallman
2005-04-25 16:05 ` font-lock-comment-delimiter-face Richard Stallman
2005-04-25 22:20 ` font-lock-comment-delimiter-face Luc Teirlinck
2005-04-26 20:58 ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-11 16:25 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-11 19:51 ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-13 1:34 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-13 3:45 ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-14 0:26 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-13 4:11 ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-13 8:21 ` font-lock-comment-delimiter-face Kim F. Storm
2005-05-13 13:15 ` font-lock-comment-delimiter-face Eli Zaretskii
2005-05-13 13:36 ` font-lock-comment-delimiter-face David Kastrup
2005-05-13 19:27 ` font-lock-comment-delimiter-face Edward O'Connor
2005-05-13 20:50 ` font-lock-comment-delimiter-face Daniel Brockman
2005-05-14 0:25 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-14 1:25 ` font-lock-comment-delimiter-face Nick Roberts
2005-05-14 15:12 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-14 22:43 ` font-lock-comment-delimiter-face Nick Roberts
2005-05-14 23:55 ` font-lock-comment-delimiter-face Paul Pogonyshev
2005-05-15 9:48 ` font-lock-comment-delimiter-face David Kastrup
2005-05-15 22:39 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-15 22:50 ` font-lock-comment-delimiter-face David Kastrup
2005-05-16 19:28 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-17 20:09 ` font-lock-comment-delimiter-face Edward O'Connor
2005-05-18 22:44 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-19 0:01 ` font-lock-comment-delimiter-face Lute Kamstra
2005-05-19 13:02 ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-19 14:44 ` font-lock-comment-delimiter-face Stefan Monnier
2005-05-19 15:01 ` font-lock-comment-delimiter-face Kim F. Storm
2005-05-20 21:57 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-19 15:01 ` font-lock-comment-delimiter-face Kim F. Storm
2005-05-19 15:46 ` font-lock-comment-delimiter-face David Kastrup
2005-05-19 16:52 ` font-lock-comment-delimiter-face Dan Nicolaescu
2005-05-20 21:56 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-21 17:51 ` Dan Nicolaescu [this message]
2005-05-15 15:58 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-18 18:02 ` font-lock-comment-delimiter-face Romain Francoise
2005-05-14 16:11 ` font-lock-comment-delimiter-face Ralf Angeli
2005-05-15 15:59 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-15 17:34 ` font-lock-comment-delimiter-face Ralf Angeli
2005-05-16 3:55 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-16 8:16 ` font-lock-comment-delimiter-face Ralf Angeli
2005-05-16 21:20 ` font-lock-comment-delimiter-face Richard Stallman
2005-05-17 7:30 ` font-lock-comment-delimiter-face Ralf Angeli
2005-05-18 23:22 ` font-lock-comment-delimiter-face Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2005-05-13 0:11 font-lock-comment-delimiter-face Lute Kamstra
2005-05-13 3:37 ` font-lock-comment-delimiter-face Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505211751.j4LHpiKE003108@scanner2.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).