From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: font-lock-comment-delimiter-face Date: Fri, 13 May 2005 00:11:38 -0400 Message-ID: <87wtq3ydmf.fsf-monnier+emacs@gnu.org> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1115957615 22089 80.91.229.2 (13 May 2005 04:13:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 13 May 2005 04:13:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 13 06:13:33 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DWRY3-0004NE-Pi for ged-emacs-devel@m.gmane.org; Fri, 13 May 2005 06:13:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DWRh8-0006qj-6K for ged-emacs-devel@m.gmane.org; Fri, 13 May 2005 00:22:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DWRfZ-0006SA-SZ for emacs-devel@gnu.org; Fri, 13 May 2005 00:21:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DWRfI-0006PJ-BP for emacs-devel@gnu.org; Fri, 13 May 2005 00:20:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DWRfG-0006Cy-NH for emacs-devel@gnu.org; Fri, 13 May 2005 00:20:42 -0400 Original-Received: from [209.226.175.188] (helo=tomts25-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DWRdN-0007m7-09; Fri, 13 May 2005 00:18:45 -0400 Original-Received: from alfajor ([67.68.217.114]) by tomts25-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050513041143.EQQB27245.tomts25-srv.bellnexxia.net@alfajor>; Fri, 13 May 2005 00:11:43 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id CA7D0D7301; Fri, 13 May 2005 00:11:38 -0400 (EDT) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Wed, 11 May 2005 12:25:45 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37061 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37061 > Seems odd to introduce a new face whose name refers to "comment" even > though the only two known uses for it are not for comments but for > email citations. > Those were the only uses yet implemented for it, > but now I've changed font-lock-fontify-syntactically-region > to use it for comment delimiters. I think this will work > for all modes. It works for C mode and Lisp mode. Taking a second look at the idea I can't help feeling like it's the wrong solution. Basically, nobody has ever requested for comment-delimiters to be hilighted differently than the comment body, so we're adding a feature that nobody asked for (and this, one-year into a feature freeze). Problem is that this feature doesn't work quite right: the border cases are non-trivial and nobody has the expertise/time/willingness to fix it. But the oddest part of all is that this was introduced because of something completely unrelated: the ability to mark mail quoting-prefix without marking the quoted text. And this, of course, has nothing to do with comments, other than an accidental reuse of font-lock-comment-face. Please, let's rename this new face to something sensible like mail-citation-prefix-face (or the same without the "-face" suffix) and stop the madness about comment delimiters. Stefan