Re: master 7a5f2b79e9: ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote.

Re: master 7a5f2b79e9: ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote.

[Michael Albinus]

Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

Hi,

>     ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote.
>
> +              (let ((filename (with-selected-window (posn-window
> +                                                     (event-end event))
> +                                (dired-file-name-at-point))))
> +                (when filename
> +                  ;; In theory x-dnd-username combined with a proper
> +                  ;; file URI containing the hostname of the remote
> +                  ;; server could be used here instead of creating a
> +                  ;; local copy of the remote file, but no program
> +                  ;; actually implements file DND according to the
> +                  ;; spec.
> +                  (when (file-remote-p filename)
> +                    (setq filename (file-local-copy filename)))
> +                  (gui-backend-set-selection 'XdndSelection filename)
> +                  (x-begin-drag '("text/uri-list"
> +                                  "text/x-dnd-username")
> +                                (if (eq 'dired-mouse-drag-files 'link)
> +                                    'XdndActionLink
> +                                  'XdndActionCopy)
> +                                nil nil t)))

Reading the code, it looks to me like you need to remove the local copy
later. Otherwise, it will trash your temp directory.

Best regards, Michael.

Re: master 7a5f2b79e9: ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote.

[Po Lu]

Michael Albinus <michael.albinus@gmx.de> writes:

> Hi,
>
>>     ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote.
>>
>> +              (let ((filename (with-selected-window (posn-window
>> +                                                     (event-end event))
>> +                                (dired-file-name-at-point))))
>> +                (when filename
>> +                  ;; In theory x-dnd-username combined with a proper
>> +                  ;; file URI containing the hostname of the remote
>> +                  ;; server could be used here instead of creating a
>> +                  ;; local copy of the remote file, but no program
>> +                  ;; actually implements file DND according to the
>> +                  ;; spec.
>> +                  (when (file-remote-p filename)
>> +                    (setq filename (file-local-copy filename)))
>> +                  (gui-backend-set-selection 'XdndSelection filename)
>> +                  (x-begin-drag '("text/uri-list"
>> +                                  "text/x-dnd-username")
>> +                                (if (eq 'dired-mouse-drag-files 'link)
>> +                                    'XdndActionLink
>> +                                  'XdndActionCopy)
>> +                                nil nil t)))
>
> Reading the code, it looks to me like you need to remove the local copy
> later. Otherwise, it will trash your temp directory.

Ah, thanks.  I always thought the old file would be removed
automatically after a while (i.e. when a new file is created).

The problem is that there's no way to know when the drop target has
finished opening the file, so the best solution is probably to remove
the old file when a new file is created.

WDYT?

Re: master 7a5f2b79e9: ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote.

[Michael Albinus]

Po Lu <luangruo@yahoo.com> writes:

>> Reading the code, it looks to me like you need to remove the local copy
>> later. Otherwise, it will trash your temp directory.
>
> Ah, thanks.  I always thought the old file would be removed
> automatically after a while (i.e. when a new file is created).
>
> The problem is that there's no way to know when the drop target has
> finished opening the file, so the best solution is probably to remove
> the old file when a new file is created.
>
> WDYT?

You must remember the file name of the "old" local copy, because it is
random.

--8<---------------cut here---------------start------------->8---
(file-local-copy "/ssh::.emacs")
=> "/tmp/tramp.k2vQK0"
--8<---------------cut here---------------end--------------->8---

An (undocumented) possibility would be to let-bind
tramp-temp-name-prefix to something else. Then you could easily identify
your own temp files.

--8<---------------cut here---------------start------------->8---
(let ((tramp-temp-name-prefix "my-own-prefix."))
  (file-local-copy "/ssh::.emacs"))
=> "/tmp/my-own-prefix.HDfgDZ"
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

Re: master 7a5f2b79e9: ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote.

[Po Lu]

Michael Albinus <michael.albinus@gmx.de> writes:

> You must remember the file name of the "old" local copy, because it is
> random.
>
> (file-local-copy "/ssh::.emacs")
> => "/tmp/tramp.k2vQK0"
>
>
> An (undocumented) possibility would be to let-bind
> tramp-temp-name-prefix to something else. Then you could easily identify
> your own temp files.
>
> (let ((tramp-temp-name-prefix "my-own-prefix."))
>   (file-local-copy "/ssh::.emacs"))
> => "/tmp/my-own-prefix.HDfgDZ"
>
> Best regards, Michael.

Thanks.