From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 7a5f2b79e9: ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote. Date: Wed, 30 Mar 2022 09:38:24 +0200 Message-ID: <87mth799fz.fsf@gmx.de> References: <164862126656.8211.8114609736677843326@vcs2.savannah.gnu.org> <20220330062106.D045CC01684@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39435"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 30 09:40:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZSw1-000A36-KS for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Mar 2022 09:40:05 +0200 Original-Received: from localhost ([::1]:50966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZSw0-0005Bg-Ft for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Mar 2022 03:40:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZSuV-000469-7D for emacs-devel@gnu.org; Wed, 30 Mar 2022 03:38:32 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:56831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZSuT-0002ed-F3 for emacs-devel@gnu.org; Wed, 30 Mar 2022 03:38:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1648625906; bh=GTFFKSBXZ73fhOMFKqmduP9bL9f0US56vl2l5iYeT1g=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Ksrh+AgZt29FwduJmITaHbuJpQvML8nRr+dKaSyjYfzeP9/pqhF9cC8KeXNCS8FGt igiVIiSLHglZPLu5rBUCuQjqxnWvYRpstMhvYv+yd24DaCeEaLtgqQU6sO/soZ0Mf7 PLWlxz2kEhapK3GgBO11H0f/K4Q9+m6busToGc1Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.151.59]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MplXz-1oNQEx0HlN-00qAdL; Wed, 30 Mar 2022 09:38:26 +0200 In-Reply-To: <20220330062106.D045CC01684@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Wed, 30 Mar 2022 02:21:06 -0400 (EDT)") X-Provags-ID: V03:K1:qCUJWNynAYKYHH52jVkYWWlAQ3N52Sui/s0ZDYp6jLvWJmSN+/H B0uKdUD19i2qMd2TVQRrH+9Mf2wffnAScO3cAqIyAN25k3LLiJM1Sw5fOujbkJ0+AIzc954 Wjo6cbaedFdWaQKSPlGR+Kbih5Ic9P/fhdG5hnwcXbs+is0hTZOTyo4ESh34V+oHLdPZKcb sGblSb5W0+WZHhh8EIfoA== X-UI-Out-Filterresults: notjunk:1;V03:K0:3yb5dnBlCEU=:ELaOjgSG3AL/QadqUKnbU3 HGzLAZmGSSnBx5Rmx+/ucz50aY48Kn9dIgqPvj4GkMNb1Vj0X5hiA3NhZECx8aRmSu2dwhj84 XbWJlyf8BPqDwGz7e5LSi6xPZa97BkEVinb5n7s+JJr5C8M1i8WxtmMnwXTxKwAj235a5H9tY unFx7SQxYKphO4ozvnXKC4I6lGiF3Kw9gHC6tGTIGDcBAm2dwdF0uQp3dgVp4ZBZB82a6hBzD UlDAzqmvJvm+PxXPcp+3agUWTqx/yDUGlMn4bnWq4laCq3bq4rhhQTG9KY1BcyUBfmM3+blV8 kUUGXWj9ckmHNpOuGe5Y7S9M9dziqNJt9W4hFFwQ3aeh2fAtqgrpIAJwQ3BenRXu3aoxDJ6OS 6b1tyRe218cuAahtNStV9+cTmu4L/5Twqo0t9FOPyWiqHn8Pjl4H9qmaGWwtldow8SCxhHwkW Cu/stdjYqL0B/a6ncCCdV7ltPzlKaj7ngjJzu7Ic1/MWHVzQVk48eCoabAjapIAZeDrlMIuRv GsnnLdrNC2CtxzauDz9Uoyj1R4QHRNDnHhuf2GfdeNZAOKyHdrwI4BlbjnuC29E666qi/KXKW dOEUmJ4use8ms7rrRHo5nDO8e5YaYPYVs/fyc3PhzKKViF6SjJ3Bg4LmPF1QHujZAVJJuhjYE Dva6J/TIgiA4krJbl25VmEvAmkxNJHVp7gyJTpG2ILEb0tYqYCW7n7mMYxoFlkQIf7ATaKegZ 7pFYP4RGm9yCUoIhHeSMOXdSfZIJSUsjowjl62Cxoun63LQ2aei7HrzbnJenXrnT/JfrRD0G Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287593 Archived-At: Po Lu via Mailing list for Emacs changes writes: Hi, > ; * lisp/dired.el (dired-mouse-drag): Create local copy if file is remote. > > + (let ((filename (with-selected-window (posn-window > + (event-end event)) > + (dired-file-name-at-point)))) > + (when filename > + ;; In theory x-dnd-username combined with a proper > + ;; file URI containing the hostname of the remote > + ;; server could be used here instead of creating a > + ;; local copy of the remote file, but no program > + ;; actually implements file DND according to the > + ;; spec. > + (when (file-remote-p filename) > + (setq filename (file-local-copy filename))) > + (gui-backend-set-selection 'XdndSelection filename) > + (x-begin-drag '("text/uri-list" > + "text/x-dnd-username") > + (if (eq 'dired-mouse-drag-files 'link) > + 'XdndActionLink > + 'XdndActionCopy) > + nil nil t))) Reading the code, it looks to me like you need to remove the local copy later. Otherwise, it will trash your temp directory. Best regards, Michael.