* Re: master 1e15500daf: Avoid a compilation warning in eval.c
[not found] ` <20220213072709.94934C00891@vcs2.savannah.gnu.org>
@ 2022-02-13 7:29 ` Po Lu
2022-02-13 7:41 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Po Lu @ 2022-02-13 7:29 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
Lars Ingebrigtsen <larsi@gnus.org> writes:
> @@ -4106,7 +4106,7 @@ specpdl_unrewind (union specbinding *pdl, int distance, bool vars_only)
> non-local, this is fine, but if it ever reverts to being
> local we may end up using this entry "in the wrong
> direction". */
> - ;
> + {};
> }
> break;
> }
That's kind of ugly -- how about removing the else branch entirely, just
leaving the comment?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 1e15500daf: Avoid a compilation warning in eval.c
2022-02-13 7:29 ` master 1e15500daf: Avoid a compilation warning in eval.c Po Lu
@ 2022-02-13 7:41 ` Lars Ingebrigtsen
2022-02-13 8:07 ` Po Lu
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-02-13 7:41 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
>> non-local, this is fine, but if it ever reverts to being
>> local we may end up using this entry "in the wrong
>> direction". */
>> - ;
>> + {};
>> }
>> break;
>> }
>
> That's kind of ugly -- how about removing the else branch entirely, just
> leaving the comment?
I assumed that Stefan was still pondering what to do here, and I just
wanted to avoid the compilation warning meanwhile.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 1e15500daf: Avoid a compilation warning in eval.c
2022-02-13 7:41 ` Lars Ingebrigtsen
@ 2022-02-13 8:07 ` Po Lu
0 siblings, 0 replies; 3+ messages in thread
From: Po Lu @ 2022-02-13 8:07 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I assumed that Stefan was still pondering what to do here, and I just
> wanted to avoid the compilation warning meanwhile.
Fair enough, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-13 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <164473722933.14008.9727236307853911285@vcs2.savannah.gnu.org>
[not found] ` <20220213072709.94934C00891@vcs2.savannah.gnu.org>
2022-02-13 7:29 ` master 1e15500daf: Avoid a compilation warning in eval.c Po Lu
2022-02-13 7:41 ` Lars Ingebrigtsen
2022-02-13 8:07 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).