unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master 1e15500daf: Avoid a compilation warning in eval.c
Date: Sun, 13 Feb 2022 15:29:00 +0800	[thread overview]
Message-ID: <875ypjmdhf.fsf@yahoo.com> (raw)
In-Reply-To: <20220213072709.94934C00891@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 13 Feb 2022 02:27:09 -0500 (EST)")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> @@ -4106,7 +4106,7 @@ specpdl_unrewind (union specbinding *pdl, int distance, bool vars_only)
>                   non-local, this is fine, but if it ever reverts to being
>                   local we may end up using this entry "in the wrong
>                   direction".  */
> -	      ;
> +	      {};
>  	  }
>  	  break;
>  	}

That's kind of ugly -- how about removing the else branch entirely, just
leaving the comment?



       reply	other threads:[~2022-02-13  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164473722933.14008.9727236307853911285@vcs2.savannah.gnu.org>
     [not found] ` <20220213072709.94934C00891@vcs2.savannah.gnu.org>
2022-02-13  7:29   ` Po Lu [this message]
2022-02-13  7:41     ` master 1e15500daf: Avoid a compilation warning in eval.c Lars Ingebrigtsen
2022-02-13  8:07       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ypjmdhf.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).