From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: woman.el broken? Date: Mon, 01 Mar 2021 21:47:14 +0100 Message-ID: <87tupu1u0d.fsf@gnus.org> References: <20210301193951.7EB04C217D7@raman-glaptop.localdomain> <878s763bah.fsf@gnus.org> <83r1ky7icm.fsf@gnu.org> <87zgzm1vvf.fsf@gnus.org> <83mtvm7hkt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19428"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 01 21:48:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGpSn-0004wF-71 for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Mar 2021 21:48:21 +0100 Original-Received: from localhost ([::1]:45916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGpSm-0001x4-9X for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Mar 2021 15:48:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGpRu-00017q-Ds for emacs-devel@gnu.org; Mon, 01 Mar 2021 15:47:27 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:37398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGpRs-0001Uy-EM; Mon, 01 Mar 2021 15:47:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8E8kHk7/JjqGZ60UbKZHgVPWlpEI+q22oLDQvzuz/eU=; b=lbn59hBmHlAUeu5jcRD2MERAcw NONtagZXu6C3Xdag30iYwUNkaYZaNJ7vB4e5NDSjzC2RON7eRWsTTKT2WziCAKsoxud+OGg4/ptGO F8jAHB07PbAYt0Mp9IlRb2LtPdbBzHITbLzBQ0DwotBYOoV5cEzIvCStFgdpHEtf/1DU=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGpRk-0005cD-5L; Mon, 01 Mar 2021 21:47:20 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXj395cUVYpICWI cnNLJCn////RZ1/kAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UDARQqGvxnA9oAAAF0SURBVDjLdZSB kYQgDEV3bxvwAw2AFLAsNEBM/zVdgqJyx2YcZfKI+T8yPh7f4hmmsXwD78fTw3iCrBHiUOEBGMB5 BxxZv1cYGAGIJ9DnrMcKkFb8AzlRmABjbQkzELLlqQ/76T7GfMxl7ny1KZsZSCG/Z0CGs8C0Hq9b VucVlkytYgCrUblXBfYpcVgTbJI+Deh0NQxVEyLb/ON3EFmDPBxcJULOcGNzbnKQfYIzgyqWnWHL 5G2hE6jEqLc1tcUhN9bCTZaAPisFkX1hVkDBf7gD5srRKJBzwlvpwDsBXLiGIBctLxEfSUAu6iNx rSpKDDZbCuBkC7PdU7AdbGjWGUha67YO6gEqaymXC3CPtsNt7gBnXgQoqI4pKIgnEPtc3aZe/4DU YDledQOqt+zrAbAlVYAOxG4voSiq6wHah7iqKm83wDegeg9wz2t315uPIF1gDKt2eBjJ3mNDdjNg s8T0VZKvbSS4RZavJUdN2PvrX+kXDyq6L9W9vbEAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDMt MDFUMjA6NDI6MjYrMDA6MDBiPUBfAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAzLTAxVDIwOjQy OjI2KzAwOjAwE2D44wAAAABJRU5ErkJggg== X-Now-Playing: Ved Buens Ende...'s _Written in Waters_: "Carrier of Wounds" In-Reply-To: <83mtvm7hkt.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Mar 2021 22:19:14 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265786 Archived-At: Eli Zaretskii writes: > Stefan, would you please make that happen? Without that, the switch > to easymenu is an incompatible change, ironic as it may be. I've poked around a bit here, and I'm not quite sure what the right fix is. Typically, in the old-style definitions, it looks like this: (define-key map [menu-bar subdir] The easy-menu incantation is: (easy-menu-define dired-mode-subdir-menu dired-mode-map "Subdir menu for Dired mode." '("Subdir" It then constructs (define-key map [menu-bar Subdir] ...) by just interning that string. Just downcasing that string would probably fix the problem (after reverting the two quick fixes I applied) -- we commonly only use small characters in these things for naming. It could also be tweaked in access_keymap_1, but... we're comparing there with EQ, and we want to continue doing that. Another way would be to allow a :name (or something) keyword to specify the symbol if we don't want the default name, so ":name 'subdir" in this case. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no