* news-mode menu and key bindings
@ 2023-02-15 17:00 Robert Pluim
2023-02-15 17:21 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Robert Pluim @ 2023-02-15 17:00 UTC (permalink / raw)
To: emacs-devel
Eli,
is this too late for emacs-29?
Robert
--
diff --git a/lisp/textmodes/emacs-news-mode.el b/lisp/textmodes/emacs-news-mode.el
index b844955e1be..c6efb4fe7ca 100644
--- a/lisp/textmodes/emacs-news-mode.el
+++ b/lisp/textmodes/emacs-news-mode.el
@@ -54,12 +54,27 @@ emacs-news-mode-map
"C-c C-s" #'emacs-news-next-untagged-entry
"C-c C-r" #'emacs-news-previous-untagged-entry
"C-c C-t" #'emacs-news-toggle-tag
+ "C-c C-d" #'emacs-news-delete-temporary-markers
"C-c C-g" #'emacs-news-goto-section
"C-c C-j" #'emacs-news-find-heading
"C-c C-e" #'emacs-news-count-untagged-entries
"C-x C-q" #'emacs-news-view-mode
"<remap> <open-line>" #'emacs-news-open-line)
+(easy-menu-define emacs-news-mode-menu emacs-news-mode-map
+ "Menu for `emacs-news-mode'."
+ '("News"
+ ["Next Untagged" emacs-news-next-untagged-entry :help "Go to next untagged entry"]
+ ["Previous Untagged" emacs-news-previous-untagged-entry :help "Go to previous untagged entry"]
+ ["Count Untagged" emacs-news-count-untagged-entries :help "Count the number of untagged entries"]
+ ["Toggle Tag" emacs-news-toggle-tag :help "Toggle documentation tag of current entry"]
+ ["Delete Tags" emacs-news-delete-temporary-markers :help "Delete all documentation tags in buffer"]
+ "--"
+ ["Goto Section" emacs-news-goto-section :help "Prompt for section and go to it"]
+ ["Goto Heading" emacs-news-find-heading :help "Prompt for heading and go to it"]
+ "--"
+ ["Enter View Mode" emacs-news-view-mode :help "Enter view-only mode"]))
+
(defvar emacs-news-view-mode-map
;; This is defined this way instead of inheriting because we're
;; deriving the mode from `special-mode' and want the keys from there.
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: news-mode menu and key bindings
2023-02-15 17:00 news-mode menu and key bindings Robert Pluim
@ 2023-02-15 17:21 ` Eli Zaretskii
2023-02-16 10:06 ` Robert Pluim
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-02-15 17:21 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 15 Feb 2023 18:00:19 +0100
>
> Eli,
>
> is this too late for emacs-29?
No, because this mode is new in Emacs 29.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: news-mode menu and key bindings
2023-02-15 17:21 ` Eli Zaretskii
@ 2023-02-16 10:06 ` Robert Pluim
2023-02-16 11:53 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Robert Pluim @ 2023-02-16 10:06 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>>>>> On Wed, 15 Feb 2023 19:21:39 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Wed, 15 Feb 2023 18:00:19 +0100
>>
>> Eli,
>>
>> is this too late for emacs-29?
Eli> No, because this mode is new in Emacs 29.
In that case, how about I rename emacs-news-toggle-tag to
emacs-news-cycle-tag, since it goes
'' -> '---' -> '+++' -> ''
Robert
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: news-mode menu and key bindings
2023-02-16 10:06 ` Robert Pluim
@ 2023-02-16 11:53 ` Eli Zaretskii
2023-02-16 14:50 ` Robert Pluim
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-02-16 11:53 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 16 Feb 2023 11:06:35 +0100
>
> >>>>> On Wed, 15 Feb 2023 19:21:39 +0200, Eli Zaretskii <eliz@gnu.org> said:
>
> >> From: Robert Pluim <rpluim@gmail.com>
> >> Date: Wed, 15 Feb 2023 18:00:19 +0100
> >>
> >> Eli,
> >>
> >> is this too late for emacs-29?
>
> Eli> No, because this mode is new in Emacs 29.
>
> In that case, how about I rename emacs-news-toggle-tag to
> emacs-news-cycle-tag, since it goes
> '' -> '---' -> '+++' -> ''
Fine by me, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: news-mode menu and key bindings
2023-02-16 11:53 ` Eli Zaretskii
@ 2023-02-16 14:50 ` Robert Pluim
0 siblings, 0 replies; 5+ messages in thread
From: Robert Pluim @ 2023-02-16 14:50 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>>>>> On Thu, 16 Feb 2023 13:53:21 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: emacs-devel@gnu.org
>> Date: Thu, 16 Feb 2023 11:06:35 +0100
>>
>> >>>>> On Wed, 15 Feb 2023 19:21:39 +0200, Eli Zaretskii <eliz@gnu.org> said:
>>
>> >> From: Robert Pluim <rpluim@gmail.com>
>> >> Date: Wed, 15 Feb 2023 18:00:19 +0100
>> >>
>> >> Eli,
>> >>
>> >> is this too late for emacs-29?
>>
Eli> No, because this mode is new in Emacs 29.
>>
>> In that case, how about I rename emacs-news-toggle-tag to
>> emacs-news-cycle-tag, since it goes
>> '' -> '---' -> '+++' -> ''
Eli> Fine by me, thanks.
Done on emacs-29
Robert
--
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-16 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15 17:00 news-mode menu and key bindings Robert Pluim
2023-02-15 17:21 ` Eli Zaretskii
2023-02-16 10:06 ` Robert Pluim
2023-02-16 11:53 ` Eli Zaretskii
2023-02-16 14:50 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).