news-mode menu and key bindings

news-mode menu and key bindings

[Robert Pluim]

Eli,

is this too late for emacs-29?

Robert
-- 

diff --git a/lisp/textmodes/emacs-news-mode.el b/lisp/textmodes/emacs-news-mode.el
index b844955e1be..c6efb4fe7ca 100644
--- a/lisp/textmodes/emacs-news-mode.el
+++ b/lisp/textmodes/emacs-news-mode.el
@@ -54,12 +54,27 @@ emacs-news-mode-map
   "C-c C-s" #'emacs-news-next-untagged-entry
   "C-c C-r" #'emacs-news-previous-untagged-entry
   "C-c C-t" #'emacs-news-toggle-tag
+  "C-c C-d" #'emacs-news-delete-temporary-markers
   "C-c C-g" #'emacs-news-goto-section
   "C-c C-j" #'emacs-news-find-heading
   "C-c C-e" #'emacs-news-count-untagged-entries
   "C-x C-q" #'emacs-news-view-mode
   "<remap> <open-line>" #'emacs-news-open-line)
 
+(easy-menu-define emacs-news-mode-menu emacs-news-mode-map
+  "Menu for `emacs-news-mode'."
+  '("News"
+    ["Next Untagged" emacs-news-next-untagged-entry :help "Go to next untagged entry"]
+    ["Previous Untagged" emacs-news-previous-untagged-entry :help "Go to previous untagged entry"]
+    ["Count Untagged" emacs-news-count-untagged-entries :help "Count the number of untagged entries"]
+    ["Toggle Tag" emacs-news-toggle-tag :help "Toggle documentation tag of current entry"]
+    ["Delete Tags" emacs-news-delete-temporary-markers :help "Delete all documentation tags in buffer"]
+    "--"
+    ["Goto Section" emacs-news-goto-section :help "Prompt for section and go to it"]
+    ["Goto Heading" emacs-news-find-heading :help "Prompt for heading and go to it"]
+    "--"
+    ["Enter View Mode" emacs-news-view-mode :help "Enter view-only mode"]))
+
 (defvar emacs-news-view-mode-map
   ;; This is defined this way instead of inheriting because we're
   ;; deriving the mode from `special-mode' and want the keys from there.

Re: news-mode menu and key bindings

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 15 Feb 2023 18:00:19 +0100
> 
> Eli,
> 
> is this too late for emacs-29?

No, because this mode is new in Emacs 29.

Thanks.

Re: news-mode menu and key bindings

[Robert Pluim]

>>>>> On Wed, 15 Feb 2023 19:21:39 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Wed, 15 Feb 2023 18:00:19 +0100
    >> 
    >> Eli,
    >> 
    >> is this too late for emacs-29?

    Eli> No, because this mode is new in Emacs 29.

In that case, how about I rename emacs-news-toggle-tag to
emacs-news-cycle-tag, since it goes
'' -> '---' -> '+++' -> ''

Robert
-- 

Re: news-mode menu and key bindings

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 16 Feb 2023 11:06:35 +0100
> 
> >>>>> On Wed, 15 Feb 2023 19:21:39 +0200, Eli Zaretskii <eliz@gnu.org> said:
> 
>     >> From: Robert Pluim <rpluim@gmail.com>
>     >> Date: Wed, 15 Feb 2023 18:00:19 +0100
>     >> 
>     >> Eli,
>     >> 
>     >> is this too late for emacs-29?
> 
>     Eli> No, because this mode is new in Emacs 29.
> 
> In that case, how about I rename emacs-news-toggle-tag to
> emacs-news-cycle-tag, since it goes
> '' -> '---' -> '+++' -> ''

Fine by me, thanks.

Re: news-mode menu and key bindings

[Robert Pluim]

>>>>> On Thu, 16 Feb 2023 13:53:21 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: emacs-devel@gnu.org
    >> Date: Thu, 16 Feb 2023 11:06:35 +0100
    >> 
    >> >>>>> On Wed, 15 Feb 2023 19:21:39 +0200, Eli Zaretskii <eliz@gnu.org> said:
    >> 
    >> >> From: Robert Pluim <rpluim@gmail.com>
    >> >> Date: Wed, 15 Feb 2023 18:00:19 +0100
    >> >> 
    >> >> Eli,
    >> >> 
    >> >> is this too late for emacs-29?
    >> 
    Eli> No, because this mode is new in Emacs 29.
    >> 
    >> In that case, how about I rename emacs-news-toggle-tag to
    >> emacs-news-cycle-tag, since it goes
    >> '' -> '---' -> '+++' -> ''

    Eli> Fine by me, thanks.

Done on emacs-29

Robert
--