Re: TTY Vertical divider face?

[Juri Linkov <juri@jurta.org>]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

>>     It makes sense to use the new `vertical-border' face not only
>>     for defining a vertical divider on character terminals, but also
>>     on X for defining the foreground color of the vertical thin line
>>     between windows.
>>
>> That seems natural.
>>
>> Is that line present even when there is a scroll bar?
>
> Yes.

I want also to fix the problem where the vertical border steals
1 pixel from the text area of the right window.  This makes some
letters indistinguishable.  The patch below draws the vertical border
1 pixel left when there are no scroll bars and no left fringes.
These screenshots demonstrate how the vertical border looks
before and after applying the patch:


[-- Attachment #2: old.png --]
[-- Type: image/png, Size: 1225 bytes --]

[-- Attachment #3: new.png --]
[-- Type: image/png, Size: 1237 bytes --]

[-- Attachment #4: Type: text/plain, Size: 883 bytes --]


Index: src/xdisp.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.1028
diff -c -r1.1028 xdisp.c
*** src/xdisp.c	25 Jun 2005 22:35:42 -0000	1.1028
--- src/xdisp.c	27 Jun 2005 23:11:18 -0000
***************
*** 22400,22405 ****
--- 22400,22408 ----
        window_box_edges (w, -1, &x0, &y0, &x1, &y1);
        y1 -= 1;
  
+       if (WINDOW_LEFT_FRINGE_WIDTH (w) == 0)
+ 	x1 -= 1;
+ 
        rif->draw_vertical_window_border (w, x1, y0, y1);
      }
    else if (!WINDOW_LEFTMOST_P (w)
***************
*** 22410,22415 ****
--- 22413,22421 ----
        window_box_edges (w, -1, &x0, &y0, &x1, &y1);
        y1 -= 1;
  
+       if (WINDOW_LEFT_FRINGE_WIDTH (w) == 0)
+ 	x0 -= 1;
+ 
        rif->draw_vertical_window_border (w, x0, y0, y1);
      }
  }

-- 
Juri Linkov
http://www.jurta.org/emacs/

[-- Attachment #5: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel