From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: TTY Vertical divider face? Date: Tue, 28 Jun 2005 02:54:15 +0300 Organization: JURTA Message-ID: <87slz3h0mg.fsf@jurta.org> References: <877jgroo1i.fsf@jurta.org> <87u0jr1xmd.fsf@jurta.org> <87mzpisgbe.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1119929400 13726 80.91.229.2 (28 Jun 2005 03:30:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 28 Jun 2005 03:30:00 +0000 (UTC) Cc: snogglethorpe@gmail.com, emacs-devel@gnu.org, rms@gnu.org, miles@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 28 05:29:59 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dn6nC-0000Ek-Ei for ged-emacs-devel@m.gmane.org; Tue, 28 Jun 2005 05:29:46 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dn6ux-0003EJ-TF for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2005 23:37:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dn6m1-0006HW-Ue for emacs-devel@gnu.org; Mon, 27 Jun 2005 23:28:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dn6lm-00069J-HL for emacs-devel@gnu.org; Mon, 27 Jun 2005 23:28:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dn6lm-00064b-7D for emacs-devel@gnu.org; Mon, 27 Jun 2005 23:28:18 -0400 Original-Received: from [194.126.101.98] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dn6lY-00064N-5A; Mon, 27 Jun 2005 23:28:04 -0400 Original-Received: from mail.neti.ee (80-235-41-107-dsl.mus.estpak.ee [80.235.41.107]) by Relayhost2.neti.ee (Postfix) with ESMTP id 240FC2EAF; Tue, 28 Jun 2005 06:23:29 +0300 (EEST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Thu, 23 Jun 2005 09:48:17 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:39718 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:39718 --=-=-= >> It makes sense to use the new `vertical-border' face not only >> for defining a vertical divider on character terminals, but also >> on X for defining the foreground color of the vertical thin line >> between windows. >> >> That seems natural. >> >> Is that line present even when there is a scroll bar? > > Yes. I want also to fix the problem where the vertical border steals 1 pixel from the text area of the right window. This makes some letters indistinguishable. The patch below draws the vertical border 1 pixel left when there are no scroll bars and no left fringes. These screenshots demonstrate how the vertical border looks before and after applying the patch: --=-=-= Content-Type: image/png Content-Disposition: inline; filename=old.png Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAM0AAABnCAIAAAAsWVG2AAAACXBIWXMAAAuJAAALiQE3ycutAAAE e0lEQVR42u2cv27qMBhHHUSHdutSiT5Au/cJytCVx0jY6WMEMbP3Cfgzg3iBssJaqUgoSK1E1QUp d4jkGzm244RwexvOGSowtuH+cuJ8Mbp4vu93u90oirbb7WKxGA6Hm81mtVoJgOJMJpMwDIMgGAwG u91uuVxOp1MhRINo4B/QzDb1+31ygZN71uv1yAVYz+C/JgxDJ8+0/QCOgfuAwnieRwh4BngGeAaA Z4BnAHgGeAZ4BoBngGcADp45fq+S2+3Mv58hH9Yz+Nc07WdbHMfKyZe0JE/tfbTz1Gy5Ip+jPPM8 T+aVPEiHFcdxHMfyJWWIdrjSuQaSkU8FnmX/zYWKCTm8rtmRTzX1mZKaPEe1uWQjrn2FSz6VrWfp ukE+dexT+9OUfCrwTCk4LNHY+6Sf1i9Z8mFfA/AM8OyYWrhEh7O6VzjzfFjP4IfuA5K7dPa7XVYj 8jlqX4P97lzJyKcCz9jvLrSpQT4l6zP2uwuV8ORTfj1jv9u+IJFPBZ4J9rsLXjrJh30N+C89O8NV HVjPAM8A8AzwDPAMAM8AzwDwDPAM8AwAzwDPAPAM8AzwDADPAM8AzwDwDH43+t89UFr4HwP2iMin jGdC9wMQQD5cNwHPAPAM8AzwDADPAM/gHDH+bijRWCCfCjxjdzsXIuK6CXgGeAaAZ4BnAHgGeAZ4 BoBn8LvQfB8wn8/JxcL7+/tmsyEHE61Wy8kzIcTd3V1dU+h0OkKI0WhUrsN6vRZCrFaruubTbreF ELPZrFyHyWQShmH1183kqJgem17NnVN2Tj/+QTXlZ3h+fi5x2EyPTa/mzik7px//oJryM/T7fW0f z/f9brcbRdF2u10sFsPhcD6fO65nMn159nc6ndFolPw1tRTVNxmY26LoeLo+4/HYcT2T6cuzv91u z2az5K+ppai+ycDcFkXH0/WJ4zgIgsFgsNvtlsvldDo1eqactab0pUbaFcsyyl0y0/D01c30vtr+ yksu8yiMx+Pb21sla236UiPtimUZ5S6ZaXj66mZ6X21/5SWXeRS0njVzj6hdkXS7XLekfNkWF5QD LCXILp/ZJUe+b9GLtXYek3BZIUyKpNvluiXly7a4oBxgKUF2+cwuOfJ9i16stfPYhTthfZbWS9tS qFRXDrzSoq2fLPNYqq5j5ilUn6X10rYUKtWVA6+0aOsnyzyWquuYeU5Sn530JtGlrlI+iX1g7jzZ Odfr9f39fen67KQ3iS51lfJJ7ANz58nOmdxvutZn7vsaRQv8304hz5T67Bwweda07BK5EIahe+d6 YLp119Lr9SaTCZu3Gs8eHx/JxQL5lIDvNwHPAM8A8AzwDPAMAM8AzwDwDPAM6o/6vVMQBIQCFZL8 htdfz25ubrrdLrmcJ1EUvb6+Pjw8tFqt6+vrl5eXp6cn9/arq6tms9loNJzWsyiKSPw82W63h8Ph 6+vr8/NTCHE4HBIfHNu/v7/zPUuGkfWZs9/v397ePj4+Li8v9/u9tMKl/eLiotFoWDzzfN8nYjg1 nhAC1eDU/AFya6+i4Xz4ygAAAABJRU5ErkJggg== --=-=-= Content-Type: image/png Content-Disposition: inline; filename=new.png Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAANMAAABnCAIAAAAVPuDtAAAACXBIWXMAAAuJAAALiQE3ycutAAAE h0lEQVR42u2cP276PBiAHUSHdutSiR6g3XuCMnTlGAk7PUYQM3tPQGEO4gJlhbUDEgpSK1F1QeIb LOWzHNs4NIFf0+eZgmOb9M2T13+iEoRh2O120zRdr9ez2Ww4HK5Wq8ViIQDKYDwex3EcRdFgMNhs NvP5fDKZCCEahAbOQjNf1O/3iQucwbxer0dcgJwHv544jr3MM9YDKBdWGMUIgoAgYB5gHgDmAeYB YB5gHgDmAeYB5gFgHvwl8zxfEB2sVtcXTcSHnAe/mKb7idzv99oDKkvkR3cdYz81y3zEp2TzgiDI IigP1PDt9/v9fp+d0poYm2uVa6Ad8anEvHwUCk1KsuZ1jSbxqWqep8Uxe46NkcoHvfZzZ+JTYc5T 5x/ZR886tX+UiU8l5mkTF0ew3HXUj3WKNfFhVwUwD+Bk5rFHT3zIeVCLFYbcI2CP3pGriE8l5gn2 6P3kIz7lm8cevecfSHxKnuexR19ocUB8ysx57NG7kxbxqcQ8wR59wQGX+LCrAr/WPMaCossLIOcB 5gFgHmAeAOYB5gHmAWAeYB4A5gHmAWAeYB4A5gHmAWAeYB5gHgDmwZ/A/OsWWgn/eUB8TmGeMP3w BxAfRlvAPADMA8wDwDzAPADMg/Nj/bVaQuOA+FRiHjvybogPoy1gHgDmAeYBYB5gHgDmAeYB5gGc AMM7jOl0SlxsJEmyWq2IQyFarZaXeUKIu7u7ukah0+kIIUaj0XEVlsulEGKxWNQ1Pu12Wz5gR1fQ GI/HcRyXP9rK+2Q7tp092GdWWT0+o6zZNTw/Px9xI23HtrMH+8wqq8dnlPWI62n+XLtOpyMzxGg0 kseOEh9k/exmy4aqf8YSTVB3HTWx5XtWC0ejkXY9RbVrt9syQyRJIo8dJZ4jvnqDZUP1fhtLNCHc ddTElu9ZLUySxHg9BwnCMOx2u2martfr2Ww2HA6n06n2ZNvuq6pdPqs5WvnnUVtzmzrq9xrra6d8 +tF4fX29vb3Nq5C/r6p2+azmaOWfR23Nbeqo32usr53y6cd9JXK0jaJoMBhsNpv5fD6ZTKw5L6+I TRq1vNycl89eWhY0prfse4sO8cZ+bArmFbFJo5aXm/Py2cuWdVRvsu8tOsQb+3FcT+W7KtpMThXO WFJoEaCpoJUY52GOfhyzt5/0U2iepwpnLCm0CNBU0EqM8zBHP47ZW6F+PP8Q82jruba1JaGKFqQ+ czjtStwND/aT73O5XN7f33uubYtOfX64IPWZw2lX4m54sB+fda5ttP2Redo87y9QyDxtnvc3KTbP k7tWPsRx7F+5HvT7ff/KvV5vPB6zmey1q/L4+EhcHBCfUuC9LWAeYB4A5gHmAWAeYB4A5gHmAWAe /Ivob8+iKCIoUCnyZ+D+N+/m5qbb7RIXkKRp+vb29vDw0Gq1rq+vX15enp6e/Muvrq6azWaj0fDK eWmaEnGQrNfr3W739fX1+fkphNjtdtIQz/Lv7+/D5slmxBo0ttvt+/v7x8fH5eXldrvNPPEpv7i4 aDQaDvOCMAwJMZyeQAiBfHB6/gOiPrfBn5jY3wAAAABJRU5ErkJggg== --=-=-= Index: src/xdisp.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v retrieving revision 1.1028 diff -c -r1.1028 xdisp.c *** src/xdisp.c 25 Jun 2005 22:35:42 -0000 1.1028 --- src/xdisp.c 27 Jun 2005 23:11:18 -0000 *************** *** 22400,22405 **** --- 22400,22408 ---- window_box_edges (w, -1, &x0, &y0, &x1, &y1); y1 -= 1; + if (WINDOW_LEFT_FRINGE_WIDTH (w) == 0) + x1 -= 1; + rif->draw_vertical_window_border (w, x1, y0, y1); } else if (!WINDOW_LEFTMOST_P (w) *************** *** 22410,22415 **** --- 22413,22421 ---- window_box_edges (w, -1, &x0, &y0, &x1, &y1); y1 -= 1; + if (WINDOW_LEFT_FRINGE_WIDTH (w) == 0) + x0 -= 1; + rif->draw_vertical_window_border (w, x0, y0, y1); } } -- Juri Linkov http://www.jurta.org/emacs/ --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--