unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Miles Bader <snogglethorpe@gmail.com>
Cc: len@reeltwo.com, emacs-devel@gnu.org, miles@gnu.org
Subject: Re: TTY Vertical divider face?
Date: Wed, 8 Jun 2005 08:00:49 +0900	[thread overview]
Message-ID: <fc339e4a05060716006ac67ab5@mail.gmail.com> (raw)
In-Reply-To: <87is0q9s4i.fsf@jurta.org>

On 6/8/05, Juri Linkov <juri@jurta.org> wrote:
> > Should it use a different face
> 
> I think yes.  I'd personally set its both background and foreground
> colors to "white" to display the vertical border as a solid
> 1-character-wide white line.

Hmmm, it's an interesting idea in that it displays a "dashless" block
by default, but still does the right thing if the terminal doesn't
handle reverse-video for some reason (this used to be an issue in the
'80s anyway :-).

However I think doing that makes it harder to follow the user's
customizations, since such a face couldn't just inherit from
`mode-line' (it could inherit, but then would have to set the
foreground to something explicit, which would often be wrong for
customized mode-line faces).

A slightly more complex alternative would be to do a "face
displayable" test on the "vertical divider" face, and if it's
displayable, use a space instead of "|" as the character...  Then just
inheriting directly from mode-line would work usually.

> > (note that the actual face that ends up being used by this code is
> > `mode-line-inactive', even though the code says MODE_LINE_FACE_ID;
> > I'm not sure why this is)?
> 
> I tried your patch, but instead of either `mode-line' or
> `mode-line-inactive' it displays the vertical border in the
> `fringe' face.  But maybe this is good.  We can reuse `fringe'
> face for the vertical border because fringes are not available
> on text-only terminals.

It sounds like it's randomly choosing some other face than what was
requested, which I think is not good even if it often works out...:-) 
I'll try to see what's going on...

-Miles
-- 
Do not taunt Happy Fun Ball.

  reply	other threads:[~2005-06-07 23:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-30  2:41 TTY Vertical divider face? Len Trigg
2005-05-31 21:50 ` Len Trigg
2005-06-06 13:27   ` Juri Linkov
2005-06-07  5:12     ` Miles Bader
2005-06-07 15:03       ` Juri Linkov
2005-06-07 23:00         ` Miles Bader [this message]
2005-06-08 12:02       ` Richard Stallman
2005-06-08 20:32   ` Juri Linkov
2005-06-14 22:31     ` Richard Stallman
2005-06-18 13:59       ` Juri Linkov
2005-06-19  3:51         ` Richard Stallman
2005-06-20  9:09           ` Miles Bader
2005-06-20 10:14             ` Miles Bader
2005-06-20 10:48               ` Miles Bader
2005-06-20 15:06               ` Johan Bockgård
2005-06-21  0:11                 ` Miles Bader
2005-06-21  0:21                   ` Miles Bader
2005-06-21 15:13                     ` Richard M. Stallman
2005-06-21 16:29                     ` Juri Linkov
2005-06-22  0:21                       ` Miles Bader
2005-06-22 13:03                         ` Juri Linkov
2005-06-23  0:54                           ` Richard M. Stallman
2005-06-23  7:48                             ` Kim F. Storm
2005-06-27 23:54                               ` Juri Linkov
2005-06-28  8:25                                 ` Kim F. Storm
2005-06-28 23:54                                   ` Juri Linkov
2005-06-29  9:12                                     ` Kim F. Storm
2005-06-28 18:47                                 ` Richard M. Stallman
2005-06-27 23:54                               ` Juri Linkov
2005-06-28  8:29                                 ` Kim F. Storm
2005-06-28 23:54                                   ` Juri Linkov
2005-06-29  9:02                                     ` Kim F. Storm
2005-06-28 18:47                                 ` Richard M. Stallman
2005-07-02  0:54                                 ` David Hunter
2005-07-02 10:53                                   ` Eli Zaretskii
2005-06-21 22:59                     ` Richard M. Stallman
2005-06-22  0:02                       ` Miles Bader
2005-06-21  2:00               ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc339e4a05060716006ac67ab5@mail.gmail.com \
    --to=snogglethorpe@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=len@reeltwo.com \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).