* Patch: Two stage build for CI
@ 2020-10-18 5:45 Anand Tamariya
2020-10-18 8:01 ` Michael Albinus
0 siblings, 1 reply; 2+ messages in thread
From: Anand Tamariya @ 2020-10-18 5:45 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
Hi,
Many a times it's easier to check results from CI for either compile or
test failure. Hence, I've broken the build into two stages.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index f4e08d59dd..45db1b8d9d 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -35,8 +35,16 @@ before_script:
- DEBIAN_FRONTEND=noninteractive apt install --no-install-recommends -y
-qq -o=Dpkg::Use-Pty=0 libc-dev gcc g++ make autoconf automake
libncurses-dev gnutls-dev git
stages:
+ - build
- test
+compile:
+ stage: build
+ script:
+ - ./autogen.sh autoconf
+ - ./configure --without-makeinfo
+ - make
+
test-all:
# This tests also file monitor libraries inotify and inotifywatch.
stage: test
[-- Attachment #2: Type: text/html, Size: 881 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Patch: Two stage build for CI
2020-10-18 5:45 Patch: Two stage build for CI Anand Tamariya
@ 2020-10-18 8:01 ` Michael Albinus
0 siblings, 0 replies; 2+ messages in thread
From: Michael Albinus @ 2020-10-18 8:01 UTC (permalink / raw)
To: Anand Tamariya; +Cc: emacs-devel
Anand Tamariya <atamariya@gmail.com> writes:
> Hi,
Hi Anand,
> Many a times it's easier to check results from CI for either compile
> or test failure. Hence, I've broken the build into two stages.
Thanks for this. In general, I agree with you. However, your patch has
some problems:
- It takes even more time after a change, because the compilation is
not extracted from the tests, but it runs additionally. Better would
be, to reuse compilation artifacts in the test stage, instead of
compilation again.
- Consequently, we would need for every test stage entry a corresponding
build stage entry. And it would also be great, if the compilation
related to test-filenotify-gio could reuse artifacts from the
compilation related to test-all.
- You call only "make", not "make bootstrap".
- There are no only: and except: clauses. For example, if somebody just
changes etc/NEWS, we don't need to run any CI.
Best regards, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-18 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-18 5:45 Patch: Two stage build for CI Anand Tamariya
2020-10-18 8:01 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).