From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Patch: Two stage build for CI Date: Sun, 18 Oct 2020 10:01:43 +0200 Message-ID: <87sgacnes8.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Anand Tamariya Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 18 10:05:21 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kU3gv-000ANN-8z for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Oct 2020 10:05:21 +0200 Original-Received: from localhost ([::1]:48838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kU3gu-0000aW-55 for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Oct 2020 04:05:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kU3dV-0007ms-Gj for emacs-devel@gnu.org; Sun, 18 Oct 2020 04:01:49 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:36973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kU3dT-00031Y-AW for emacs-devel@gnu.org; Sun, 18 Oct 2020 04:01:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603008105; bh=QYlPsLngf9TC6+gK5Aw1boWKga6fRnICXlKU4Zd/u5I=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=HFwL9XFYCAGSXDon6yvOmX1EGpqX2t4m06fUBF7ckOnn1jFJbsRCsPnJ3Fmb5hb5d gdRebLeh63QT2qhSdHWeteFBqAeHwrpDOaOORhm8vGRn0o54++foNnIzSi8MRG1cuS jH7JxnRz+39Mlrf3+jlIZI0Qw+NHE3o+dCkN9diw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.52.21]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MacOW-1jrynD0Bcg-00c7I3; Sun, 18 Oct 2020 10:01:45 +0200 In-Reply-To: (Anand Tamariya's message of "Sun, 18 Oct 2020 11:15:00 +0530") X-Provags-ID: V03:K1:7uq0iGbizSGUdUYdWlymA6YZQ1le0aFSqTIaD5i75g9UiQifseN ZcPyjoM3SFdWd7ZkqSQ14xGPAt0hYi4dxRJWm3Ab0wxRISqw/tUOQg+Ix2ZTL1vARfq+Oty x2hpNHGwxM5G5/Ektas2yKKRQNnJQhQvJI0U2wjJ7/o+ubE4UFbnuNxw9syMtfvuGQfBMJi WEuvxG5gSxEvaxIe3U31Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:T/hASNy4ZD8=:XkqVgWEaCwKqM3FeVYYFSJ +INiD6JY7jJjqJx/8X5Kvw1BRfU3xX5+H7Wbo0saKJY1Js4pakUNprBc+WK+J+nKM8L5W4iAm fZrl9ABNa1iLjdwUQuJDUhKbMPBtPP8ydPb8T8XbrrDpn1eNtJ65cN9p+RjomCa2ynQmcsSVs Qe8jgUOh4LFkjLbF50+OOEv0y0yWCh2m3SX1msCFA/y1N5B4g7ae5YY6Nq6OUxrz3QPRnlx/7 imRFqG1bBuGhkMWPm+YoSq/htsquU+oD5evjyCIBSaWU5AvL1/KJdy8WkBZt+hgvOpg3J9YqF S6nbS7MkVj+k2d5wYhpdfwBmRDnkIzm7hxlr5v6roqNXBTbnfEsxdL0xSqOAXbZ/I8q64kDT8 rFqRmUmf5bQ8l5gKCwcC+ZDEOur4NsAka1GlHIzOCPLeoggffcwPR3zBFhgBghK6dpodING69 6CTdwSg7nnVLrQ2EL272TJ0tz1hkPo7HaiURxi/6CiRb/YHI05mKMgG8+18iYp42eQ6vPaXan oDjHOcZLr1d6zSUU0OIV7Fl7qMzfh+2XWgzdjUrbiQw0iK6iJoHohKcDQADVVh+hcHLVJs3uz iky77rZmhMBscDNYtKAh4PUylgzQvwCOEnW09fihPHsFVA3Q4P0VWzqYltBx+jz4hfBA1yDNX BiAgKCpAa9LmXdUgh3LmrWXuAk2eA+U+5hfG3gKczv6mcjXHfzXsxDtlnbGL3xshLYbGmYM8A gnwPBkAsf5ujFy6S4efIutvtq633dSAX/ezxmQlbOi+SaAjRt1eTm9yIS6HWL+zG92VzD4/R Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/18 04:01:45 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258009 Archived-At: Anand Tamariya writes: > Hi, Hi Anand, > Many a times it's easier to check results from CI for either compile > or test failure. Hence, I've broken the build into two stages. Thanks for this. In general, I agree with you. However, your patch has some problems: - It takes even more time after a change, because the compilation is not extracted from the tests, but it runs additionally. Better would be, to reuse compilation artifacts in the test stage, instead of compilation again. - Consequently, we would need for every test stage entry a corresponding build stage entry. And it would also be great, if the compilation related to test-filenotify-gio could reuse artifacts from the compilation related to test-all. - You call only "make", not "make bootstrap". - There are no only: and except: clauses. For example, if somebody just changes etc/NEWS, we don't need to run any CI. Best regards, Michael.