From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding
Date: Tue, 09 Apr 2019 00:07:06 +0100 [thread overview]
Message-ID: <87r2acayg5.fsf@tcd.ie> (raw)
In-Reply-To: <20190408204944.85B29209A7@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 8 Apr 2019 16:49:44 -0400 (EDT)")
monnier@iro.umontreal.ca (Stefan Monnier) writes:
> branch: master
> commit 36dc39bfbf1a307769bd62dbe1311a1935737b51
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * lisp/gnus/gnus-sum.el: Prepare for lexical-binding
[...]
> (gnus-summary-move-article): Use dolist.
[...]
> @@ -9979,7 +10038,7 @@ ACTION can be either `move' (the default), `crosspost' or `copy'."
> (crosspost "Crosspost" "Crossposting")))
> (copy-buf (save-excursion
> (nnheader-set-temp-buffer " *copy article*")))
> - art-group to-method new-xref article to-groups
> + art-group to-method new-xref to-groups
> articles-to-update-marks encoded)
> (unless (assq action names)
> (error "Unknown action %s" action))
> @@ -10029,8 +10088,7 @@ ACTION can be either `move' (the default), `crosspost' or `copy'."
> (or (car select-method)
> (gnus-group-decoded-name to-newsgroup))
> articles)
> - (while articles
> - (setq article (pop articles))
> + (dolist (article articles)
> ;; Set any marks that may have changed in the summary buffer.
> (when gnus-preserve-marks
> (gnus-summary-push-marks-to-backend article))
The dolist and while implementations aren't equivalent here (see my own
attempt at this[1] and the resulting bug[2]), so I took the liberty of
re-applying Yamaoka-san's fix[3] on top of your changes in the meantime.
[1: 03e916beb0]: Fix Gnus duplicate article unsuppression
2019-03-24 10:11:29 -0700
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=03e916beb0186f3707cd238650298870bf471575
[2]: https://debbugs.gnu.org/33653#134
[3: 3e5e097fdf]: Make `move article' work again (bug#33653)
2019-04-08 23:55:09 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3e5e097fdf056f4b3440993dd25ebdbad436abc3
Thanks,
--
Basil
next parent reply other threads:[~2019-04-08 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190408204943.16965.86497@vcs0.savannah.gnu.org>
[not found] ` <20190408204944.85B29209A7@vcs0.savannah.gnu.org>
2019-04-08 23:07 ` Basil L. Contovounesios [this message]
2019-04-09 1:50 ` [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding Stefan Monnier
2019-04-09 15:11 ` Andy Moreton
2019-04-09 15:38 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2acayg5.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).