From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding
Date: Tue, 09 Apr 2019 16:38:12 +0100 [thread overview]
Message-ID: <875zrnchp7.fsf@tcd.ie> (raw)
In-Reply-To: <vz1r2ab8b8q.fsf@gmail.com> (Andy Moreton's message of "Tue, 9 Apr 2019 16:11:17 +0100")
Andy Moreton <andrewjmoreton@gmail.com> writes:
> On Mon 08 Apr 2019, Stefan Monnier wrote:
>
>>> The dolist and while implementations aren't equivalent here (see my own
>>> attempt at this[1] and the resulting bug[2]), so I took the liberty of
>>> re-applying Yamaoka-san's fix[3] on top of your changes in the meantime.
>>
>> Duh, indeed, thanks,
>>
>>
>> Stefan
>
> As this problem has now bitten twice, perhaps it merits a comment in the
> code to prevent it being "fixed" again...
Good point; done[1].
[1: e1a457e635]: ; Warn of while/dolist pitfall in gnus-sum.el
2019-04-09 16:32:27 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e1a457e63530cd566a1bc2957b70221bb6f76984
Thanks,
--
Basil
prev parent reply other threads:[~2019-04-09 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190408204943.16965.86497@vcs0.savannah.gnu.org>
[not found] ` <20190408204944.85B29209A7@vcs0.savannah.gnu.org>
2019-04-08 23:07 ` [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding Basil L. Contovounesios
2019-04-09 1:50 ` Stefan Monnier
2019-04-09 15:11 ` Andy Moreton
2019-04-09 15:38 ` Basil L. Contovounesios [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zrnchp7.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).