From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding Date: Tue, 09 Apr 2019 00:07:06 +0100 Message-ID: <87r2acayg5.fsf@tcd.ie> References: <20190408204943.16965.86497@vcs0.savannah.gnu.org> <20190408204944.85B29209A7@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="121171"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 01:08:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDdN1-000VRP-67 for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 01:08:07 +0200 Original-Received: from localhost ([127.0.0.1]:60243 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDdN0-0002NQ-4z for ged-emacs-devel@m.gmane.org; Mon, 08 Apr 2019 19:08:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDdMH-0002LC-OF for emacs-devel@gnu.org; Mon, 08 Apr 2019 19:07:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDdMG-0003Gf-Iv for emacs-devel@gnu.org; Mon, 08 Apr 2019 19:07:21 -0400 Original-Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:39400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDdMC-00035v-Aa for emacs-devel@gnu.org; Mon, 08 Apr 2019 19:07:18 -0400 Original-Received: by mail-ed1-x544.google.com with SMTP id n9so4330213edt.6 for ; Mon, 08 Apr 2019 16:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CSTcmvOxsPqPvAjpRiiDJ4a11PPAq4N3cjD3JBfnOd8=; b=S1tdf0qSVoyoesK+9nBIEJT2tPlYlDjnzfYE8dYKRXsNH4fWx1oarTAL08nLhFcUXE DzysqQg6GdtmuBqHIkiJ77aNZEPRSjbjZWUsSiTiN4WT2CFy1STBrh/r0lcKmKh0eCFa OLg2ELZgyaaIp1v1Zrn8W6jDHbDGg48+byVODQOVGBjWJ2RspIvwcqk7Je2sYZ4lvWFX XK/zNC8ityHkS6nH4Wu4zChX9BG4/NqAG0NAfUvZ2KdWdTH4ntUI6Ui4rNpDf6PN40VP QzpKjiF4oCzd84wL+gTsgAOGHW33YJspy3uN8U7/1yWEJ7LADho0I7zH4EGIJ1AN9mUw 01nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=CSTcmvOxsPqPvAjpRiiDJ4a11PPAq4N3cjD3JBfnOd8=; b=DT8jtjxpnFxGY8NY89D7uxTWMJs8arhwXilnyvNoe7rMosFkQyDL4eLD96PbnmSwpy RqG2Nf6Nd0+yyUOdt8k2PpGTTsvESMKjBv74Il9CKLbCY+HbS0tDTVbcXE61i0ajOY1z bI7npXeky/euTQyot6Hm2x/Zwr8MSvEgeicUD2A5WBtlxndkh239DaTm5f/DS7PpedwX ll3k0LuDS06FidTxUPG6VPsl/YCMWr8WLsQ1v0zUMklLkfgzGWFv4Y97EHd9vpCMj7Xh DcRjdIvZKZ2GMhfdzDzeqvbQ+iIePb8Z3MQTam22IBnFTcQLN4N4sPxjmDRIPaMl1fwV WIBg== X-Gm-Message-State: APjAAAUwFux1rVdAG0/0Q71qVXC0FmKtFaHsJEdj6U2mO4E59X0t/bqD HgDpz6oPArvTEKyKxZoHALK+ubMN2Kzw/7nL X-Google-Smtp-Source: APXvYqy6FaVMB59I3PLwg3KUUJ7OzG+Nn6hU3+VMr2M1HArTsO6SBtA0zC57rtcHPjj9sPlnQ41XSA== X-Received: by 2002:a50:ec89:: with SMTP id e9mr20925117edr.252.1554764828561; Mon, 08 Apr 2019 16:07:08 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id q12sm5616399eja.45.2019.04.08.16.07.07 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Apr 2019 16:07:07 -0700 (PDT) In-Reply-To: <20190408204944.85B29209A7@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 8 Apr 2019 16:49:44 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235140 Archived-At: monnier@iro.umontreal.ca (Stefan Monnier) writes: > branch: master > commit 36dc39bfbf1a307769bd62dbe1311a1935737b51 > Author: Stefan Monnier > Commit: Stefan Monnier > > * lisp/gnus/gnus-sum.el: Prepare for lexical-binding [...] > (gnus-summary-move-article): Use dolist. [...] > @@ -9979,7 +10038,7 @@ ACTION can be either `move' (the default), `crosspost' or `copy'." > (crosspost "Crosspost" "Crossposting"))) > (copy-buf (save-excursion > (nnheader-set-temp-buffer " *copy article*"))) > - art-group to-method new-xref article to-groups > + art-group to-method new-xref to-groups > articles-to-update-marks encoded) > (unless (assq action names) > (error "Unknown action %s" action)) > @@ -10029,8 +10088,7 @@ ACTION can be either `move' (the default), `crosspost' or `copy'." > (or (car select-method) > (gnus-group-decoded-name to-newsgroup)) > articles) > - (while articles > - (setq article (pop articles)) > + (dolist (article articles) > ;; Set any marks that may have changed in the summary buffer. > (when gnus-preserve-marks > (gnus-summary-push-marks-to-backend article)) The dolist and while implementations aren't equivalent here (see my own attempt at this[1] and the resulting bug[2]), so I took the liberty of re-applying Yamaoka-san's fix[3] on top of your changes in the meantime. [1: 03e916beb0]: Fix Gnus duplicate article unsuppression 2019-03-24 10:11:29 -0700 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=03e916beb0186f3707cd238650298870bf471575 [2]: https://debbugs.gnu.org/33653#134 [3: 3e5e097fdf]: Make `move article' work again (bug#33653) 2019-04-08 23:55:09 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3e5e097fdf056f4b3440993dd25ebdbad436abc3 Thanks, -- Basil