Re: native-comp *Warnings* buffer

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Andrea Corallo via "Emacs development discussions."
<emacs-devel@gnu.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Richard Stallman <rms@gnu.org> writes:
>>
>>> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
>>> [[[ whether defending the US Constitution against all enemies,     ]]]
>>> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>>>
>>>   > I think "stealth" compilation performed opportunistically in the
>>>   > background should indeed not display any warnings (by default).
>>>
>>> I understand the reason for saying that, but... would this mean that a
>>> compilation of that meaterial won't happen later?  Is there a chance
>>> that you'll never see the warnings that compilation generates?
>>
>> This wouldn't affect the actual compilation at all. It could affect
>> whether the user sees the warnings or not, if we default to not popping
>> up the *Warnings* buffer. They might still go looking for the buffer, or
>> stumble upon it by accident, though.
>>
>> I've attached a patch that provides a 'silent option to
>> `native-comp-async-report-warnings-errors'. In this patch the default is
>> still t, though we could easily default to 'silent if that seems
>> desirable.
>
> Hi Eric,
>
> thanks for the patch, it sounds like a good idea.
>
> Just a small nit below otherwise LGTM.
>
>>>From 01516b21e71862f3496e3a1f75bb86d436afaa3b Mon Sep 17 00:00:00 2001
>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Date: Sat, 15 May 2021 09:36:05 -0700
>> Subject: [PATCH] Provide a 'silent option for
>>  native-comp-asyncreport-warnings-errors
>>
>> * lisp/emacs-lisp/comp.el (native-comp-async-report-warnings-errors):
>> Set to 'silent to log warnings, but not pop up the *Warnings* buffer.
>> * lisp/emacs-lisp/comp.el (comp-accept-and-process-async-output):
>> Check value.
>> ---
>>  lisp/emacs-lisp/comp.el | 29 +++++++++++++++++++----------
>>  1 file changed, 19 insertions(+), 10 deletions(-)
>>
>> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
>> index 3e7f17ef1c..8fa9dee1ed 100644
>> --- a/lisp/emacs-lisp/comp.el
>> +++ b/lisp/emacs-lisp/comp.el
>> @@ -148,8 +148,13 @@ native-comp-async-report-warnings-errors
>>  environment, it is more sensitive to such omissions, and might be
>>  unable to compile such Lisp source files correctly.
>>  
>> -Set this variable to nil if these warnings annoy you."
>> -  :type 'boolean
>> +Set this variable to nil to suppress warnings altogether, or to
>> +the symbol `quiet' to log warnings but not pop up the *Warnings*
>               ^^^
>               `silent'?

Whoops! I went back and forth on the symbol to use, and apparently
settled on "borth". Thanks.

I forgot to say, I only put this check on one of the three
`display-warning' call-sites in this file, because the others looked
like fairly specific situations that the user should be bothered about.
If they should all have it, I can do that, too.

Eric