From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: native-comp *Warnings* buffer Date: Sun, 16 May 2021 14:25:28 -0700 Message-ID: <87r1i6z7zr.fsf@ericabrahamsen.net> References: <87k0o2z9pr.fsf@ericabrahamsen.net> <83y2chzvxw.fsf@gnu.org> <87czttxquo.fsf@ericabrahamsen.net> <87y2cfwbz5.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33648"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Richard Stallman , Stefan Monnier , Andrea Corallo To: Andrea Corallo via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 16 23:26:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liOHN-0008a6-Jq for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 23:26:29 +0200 Original-Received: from localhost ([::1]:35828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liOHM-0003lS-Cd for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 17:26:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liOGa-00036X-Jz for emacs-devel@gnu.org; Sun, 16 May 2021 17:25:40 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:55308 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liOGW-0006bB-1U; Sun, 16 May 2021 17:25:37 -0400 Original-Received: from localhost (c-71-197-184-122.hsd1.wa.comcast.net [71.197.184.122]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id DFB26FA02E; Sun, 16 May 2021 21:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1621200333; bh=Zxha4mv+ZmxkH0DDQxXKM7prn46if7itvzYkDVCs7/0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=uSkAuISHx1odNkeAnC3IYrahL447DUbx91jWKYuKk1ErCe2wftIF5BQF+C1QVGPtI i4WsZLRnTp3d7nxpRH1kvSoqWzctaCW6g/NpUngbYT1tyT5G7pSk0ALBreVUsLswwK 9pEvnZE/2DluNULGWLY64z8V16PO9+KrWw4ewsys= In-Reply-To: (Andrea Corallo via's message of "Sun, 16 May 2021 20:04:13 +0000") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269381 Archived-At: Andrea Corallo via "Emacs development discussions." writes: > Eric Abrahamsen writes: > >> Richard Stallman writes: >> >>> [[[ To any NSA and FBI agents reading my email: please consider ]]] >>> [[[ whether defending the US Constitution against all enemies, ]]] >>> [[[ foreign or domestic, requires you to follow Snowden's example. ]]] >>> >>> > I think "stealth" compilation performed opportunistically in the >>> > background should indeed not display any warnings (by default). >>> >>> I understand the reason for saying that, but... would this mean that a >>> compilation of that meaterial won't happen later? Is there a chance >>> that you'll never see the warnings that compilation generates? >> >> This wouldn't affect the actual compilation at all. It could affect >> whether the user sees the warnings or not, if we default to not popping >> up the *Warnings* buffer. They might still go looking for the buffer, or >> stumble upon it by accident, though. >> >> I've attached a patch that provides a 'silent option to >> `native-comp-async-report-warnings-errors'. In this patch the default is >> still t, though we could easily default to 'silent if that seems >> desirable. > > Hi Eric, > > thanks for the patch, it sounds like a good idea. > > Just a small nit below otherwise LGTM. > >>>>From 01516b21e71862f3496e3a1f75bb86d436afaa3b Mon Sep 17 00:00:00 2001 >> From: Eric Abrahamsen >> Date: Sat, 15 May 2021 09:36:05 -0700 >> Subject: [PATCH] Provide a 'silent option for >> native-comp-asyncreport-warnings-errors >> >> * lisp/emacs-lisp/comp.el (native-comp-async-report-warnings-errors): >> Set to 'silent to log warnings, but not pop up the *Warnings* buffer. >> * lisp/emacs-lisp/comp.el (comp-accept-and-process-async-output): >> Check value. >> --- >> lisp/emacs-lisp/comp.el | 29 +++++++++++++++++++---------- >> 1 file changed, 19 insertions(+), 10 deletions(-) >> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el >> index 3e7f17ef1c..8fa9dee1ed 100644 >> --- a/lisp/emacs-lisp/comp.el >> +++ b/lisp/emacs-lisp/comp.el >> @@ -148,8 +148,13 @@ native-comp-async-report-warnings-errors >> environment, it is more sensitive to such omissions, and might be >> unable to compile such Lisp source files correctly. >> >> -Set this variable to nil if these warnings annoy you." >> - :type 'boolean >> +Set this variable to nil to suppress warnings altogether, or to >> +the symbol `quiet' to log warnings but not pop up the *Warnings* > ^^^ > `silent'? Whoops! I went back and forth on the symbol to use, and apparently settled on "borth". Thanks. I forgot to say, I only put this check on one of the three `display-warning' call-sites in this file, because the others looked like fairly specific situations that the user should be bothered about. If they should all have it, I can do that, too. Eric