unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Andrea Corallo via "Emacs development discussions."
	<emacs-devel@gnu.org>
Cc: Andrea Corallo <akrl@sdf.org>
Subject: Re: native-comp *Warnings* buffer
Date: Thu, 13 May 2021 15:00:46 -0700	[thread overview]
Message-ID: <8735uqz435.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87bl9ez5an.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 13 May 2021 14:34:40 -0700")

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Andrea Corallo via "Emacs development discussions."
> <emacs-devel@gnu.org> writes:
>
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>>
>>>> I understand the utility of having these warnings, but does the buffer
>>>> need to be popped up every thirty seconds? Couldn't it just be displayed
>>>> once, when it's created, and then left alone? Compilation has been going
>>>> on for several minutes since rebuilding Emacs, and it's actually hard to
>>>> use with *Warnings* occupying my other window every few seconds!
>>>
>>> I should say that I know about
>>> `native-comp-async-report-warnings-errors', and I'd actually like to see
>>> these warnings (as many of them are about my own code :(), I'd just like
>>> to have them in the background.
>>
>> Hi Eric,
>>
>> unfortunately new warnings are showed when they are found while
>> compiling.  I agree this is annoying but at the same time I'm not sure
>> this behavior wrong.
>>
>> Anyway in comp.el we just call `display-warning'.  If there's a better
>> way to handle this any suggestion or patch is very welcome :)
>
> It looks like `warning-suppress-types' might do it!
>
> List of warning types not to display immediately.
> If any element of this list matches the TYPE argument to ‘display-warning’,
> the warning is logged nonetheless, but the warnings buffer is
> not immediately displayed.
> The element must match an initial segment of the list TYPE.
> Thus, (foo bar) as an element matches (foo bar)
> or (foo bar ANYTHING...) as TYPE.
> If TYPE is a symbol FOO, that is equivalent to the list (FOO),
> so only the element (FOO) will match it.
>
> Let-binding this with 'comp in the value should do it.
>
> We could add 'suppress or 'quiet as an alternate value
> `native-comp-async-report-warnings-errors', and use that to optionally
> change the value of `warning-suppress-types'.

Well I guess I could have figured this out myself: the clickable
"Disable showing" button at the end of every warning does exactly this:
customizes `warning-suppress-types' so that the '(comp) warnings are
still logged to *Warnings*, but it doesn't pop up the buffer. This seems
like enough customization to me, and there's no need to add any code!

Actually it looks like `native-comp-async-report-warnings-errors' could
be replaced by customization of `warning-suppress-log-types', which will
prevent logging altogether. Anyway, problem solved!



  reply	other threads:[~2021-05-13 22:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13 19:59 native-comp *Warnings* buffer Eric Abrahamsen
2021-05-13 20:20 ` Eric Abrahamsen
2021-05-13 21:28   ` Andrea Corallo via Emacs development discussions.
2021-05-13 21:34     ` Eric Abrahamsen
2021-05-13 22:00       ` Eric Abrahamsen [this message]
2021-05-14  6:28       ` Eli Zaretskii
2021-05-14  2:30     ` T.V Raman
2021-05-14  6:42       ` Eli Zaretskii
2021-05-14  6:11 ` Eli Zaretskii
2021-05-14 15:44   ` Eric Abrahamsen
2021-05-14 16:23     ` Stefan Monnier
2021-05-14 16:46       ` Eric Abrahamsen
2021-05-14 16:54         ` Eric Abrahamsen
2021-05-15  5:33       ` Richard Stallman
2021-05-16  4:15         ` Eric Abrahamsen
2021-05-16 14:06           ` Jump to source of warning was " T.V Raman
2021-05-16 20:04           ` Andrea Corallo via Emacs development discussions.
2021-05-16 21:25             ` Eric Abrahamsen
2021-05-17  6:11               ` Andrea Corallo via Emacs development discussions.
2021-05-17  3:23           ` Richard Stallman
2021-05-17  6:16             ` Eli Zaretskii
2021-05-16  5:12         ` Stefan Monnier
2021-05-16  5:30           ` Eli Zaretskii
2021-05-16  6:03             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735uqz435.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).